> On Jan 6, 2018, at 12:02 PM, Craig Russell <[email protected]> wrote: > >>>> My adding function that picked up work that Brent used to do has meant >>>> that we have had to do cleanup. This function is only really tested once >>>> a month. Whether this is the last month with problems or not is something >>>> we will only find out after the next board meeting. >>> I wonder if there is a way to unit test the new functionality in agenda. If >>> the tricky part is editing committee-info and updating ldap, a function >>> like ASF::Module.change_pmc_chair(project, chair) that does both >>> ASF::Committee.change_pmc_chair(project, chair) and ASF::LDAP.bind. >>> I realize I'm helping design something that I know almost zero about, but >>> that's what you get with retired people. ;-) >> >> I encourage you to look at the current test suite for the board agenda tool. >> While the test you describe above is most emphatically NOT an example of >> the first test I would suggest you add, there undoubtedly are quite a number >> of simpler tests that could be added. >>
I think it might be good to use the real LDAP instance for testing. That way we know that the changes will really work. I know that sebb has been testing using a test apache id. How about adding a test_pmc and test_podling to the LDAP service, and adding test_clr and test_sebb as users? We can then test adding/removing/changing chairs/making members/etc. Craig Craig L Russell Secretary, Apache Software Foundation [email protected] http://db.apache.org/jdo
