Hi Shane, > On Feb 9, 2019, at 5:07 AM, Shane Curcuru <[email protected]> wrote: > > Can;'t type enough for code yet, but miss coding, so... ideas: > > When verifying zig, you want workbench to: > > - IF we get here: (i.e. there was an error gettign key) > https://github.com/apache/whimsy/blob/master/www/secretary/workbench/views/actions/check-signature.json.rb#L40
First, the entire error message should be displayed instead of just "no data". > > - And if > err.include? "gpg: Can't check signature: No public key" or > err.include? "gpg: Can't check signature: public key not found" > > - Then Do: enable the action that sends pubkey.erb (so you can push the > button - or do you want it to automatically send that upload email)? The action to send pub key.erb is always enabled. But the message should have the command that failed, e.g. http://pgpkeys.mit.edu/pks/lookup?search=91CDDE11&op=index That way, the sender has some idea of which key was being requested. > > - ELSE: (other error like proxy/timeout) > - Disable the pubkey.erb No need. > - Allow the Secretary to re-process the check sig action. > > Do you want it to simply give you the button to immediately re-chceck > for the key, That would be a nice option. Just clicking on the .pdf file doesn't automatically try to download the public key from what I can tell. > or do you want to leave this whole msg and come back later? Just having the entire error message displayed with no further editing/analysis is fine. From the message, secretary can decide whether to send the "upload pub key" message or not. And in fact, sometimes it takes a couple of upload messages before the sender gets around to uploading the key. And having the command as part of the message might allow the sender to just click on the link and see if they are successful accessing their own public key. Craig > > -- > > - Shane > Director & Member > The Apache Software Foundation > > Craig Russell wrote on 2/8/19 8:18 PM: >> Hi, >> >> When a document has an associated .asc file, whimsy automatically tries to >> download the public key in order to verify the signature. >> >> But the key server is often busy and just cannot service the request timely. >> >> The current behavior of whimsy does not distinguish among at least three >> cases: >> >> No key found >> Timeout >> Proxy error >> >> No key found is the only case where the secretary should send the "upload >> public key" message to the submitter. >> >> In the other two cases, the secretary should retry (later) until a >> definitive No key found error is received or the public key is downloaded. >> >> Can the actual error be extracted from the message to avoid confusion? >> >> Thanks, >> >> Craig >> >> Craig L Russell >> Secretary, Apache Software Foundation >> [email protected] http://db.apache.org/jdo >> > Craig L Russell Secretary, Apache Software Foundation [email protected] <mailto:[email protected]> http://db.apache.org/jdo <http://db.apache.org/jdo>
