clr-apache commented on pull request #120:
URL: https://github.com/apache/whimsy/pull/120#issuecomment-886241940
I like the approach of creating a new common method sn, givenname = def
ldap_parsecn(cn, familyfirst)
This would eliminate a lot of unneeded parameters and variables and localize
changes.
I'd also add two parameters that should default to 1: givenNameLength and
snLength. A recent example is (anonymized) George De Silva. We can have the
default still be
givenName George
sn Silva
and then the secretary needs to type De into the sn field. Silva is not the
sn, but De Silva is.
I've been looking for the way to express this in the icla panel and it's a
bit awkward. We would need four buttons: increase and decrease givenName length
and increase and decrease sn length.
(+) Given Name (-) [George_________________________________]
(+) sn (-) [Silva_________________________________]
If secretary pushes the (+) button, the display changes to
(+) sn (-) [De Silva_________________________________]
Pushing the (+) button again would give
(+) sn (-) [George De Silva_________________________________]
And pushing the (-) button would revert the field to the proper result.
Again, I don't know how to express the (+) and (-) in Vue/whimsy terms, but
I think the (+) and (-) are probably self-explanatory for any of the secretary
team to use.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
