[ 
https://issues.apache.org/jira/browse/WHIRR-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13104575#comment-13104575
 ] 

Adrian Cole commented on WHIRR-371:
-----------------------------------

only thing is that in the patch there seems to be an inconsistency where 
hyphens are used rather than dots:

ex. whirr.firewall-rules-serviceA should be whirr.firewall-rules.serviceA 
(inside testFirewallRules() + also the documentation)

otherwise +1

I'm keen getting this in, as we will need it for WHIRR-385

> Allow defining additional firewall rules
> ----------------------------------------
>
>                 Key: WHIRR-371
>                 URL: https://issues.apache.org/jira/browse/WHIRR-371
>             Project: Whirr
>          Issue Type: Improvement
>          Components: core
>            Reporter: Karel Vervaeke
>         Attachments: WHIRR-371.patch, WHIRR-371.patch, WHIRR-371.patch
>
>
> Users should have more control over the firewall rules, by adding one or more 
> properties to the whirr properties file

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to