[
https://issues.apache.org/jira/browse/WHIRR-273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13134464#comment-13134464
]
Andrei Savu commented on WHIRR-273:
-----------------------------------
Jhey some of the things I noticed while taking a quick look at the patch:
* please do not include *.log files and .swp files in the patch
* we've switched back to using regular instances for integration testing
(remove whirr.aws-ec2-spot-price)
* in start_riak() you've wrote "bin riak start" - what is "bin" used for?
* we are using curl to download artefacts - take a look at install_tarball() -
the important part is that you should have some sort of retry loop.
* in configure_riak() you've wrote "bin riak-admin reip [email protected]
riak@$PRIVATE_IP". What is "bin" for?
* remove unused methods like getHosts() and the RiakCluster class
* I don't think we need to include in the changeset riak-local-nodes-byon.yaml
As I said before (offline) the easies way to try scrips is on local VMs line by
line and as you get them working you can move to BYON and after that to cloud
providers.
As you update the patch towards making it work I will get back to you with more
updates.
> Add Riak as a service
> ---------------------
>
> Key: WHIRR-273
> URL: https://issues.apache.org/jira/browse/WHIRR-273
> Project: Whirr
> Issue Type: New Feature
> Components: new service
> Reporter: Andrei Savu
> Assignee: Jhey Tompkins
> Attachments: WHIRR-273-Add-Riak-as-a-Service.patch
>
>
> "Riak is a Dynamo-inspired database that is being used in production by
> companies like Mozilla and Comcast. Riak scales predictably and easily and
> simplifies development by giving users the ability to quickly prototype,
> test, and deploy their applications.
> A truly fault-tolerant system, Riak has no single point of failure. No
> machines are special or central in Riak, so developers and operations
> professionals can decide exactly how fault-tolerant they want and need their
> applications to be."
> -- http://wiki.basho.com/Home.html
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
