Good. Please keep me posted. Going though whirr-399, will refactor Bootstrap/Configure/Destroy ClusterAction because I'm seeing a lot of duplicate code (and thread leaks as the executors are never shutdown, not a problem for the command line client but would be if whirr is used as a lib).
-david On Nov 4, 2011, at 8:22 PM, Andrei Savu wrote: > Nice to see this fixed. I will add an itest in WHIRR-409. > On Nov 5, 2011 2:34 AM, "David Alves (Updated) (JIRA)" <[email protected]> > wrote: > >> >> [ >> https://issues.apache.org/jira/browse/WHIRR-398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel] >> >> David Alves updated WHIRR-398: >> ------------------------------ >> >> Attachment: WHIRR-398.patch >> >> minor correction in the test. >> >>> Implement the execution of scripts on DestroyClusterAction >>> ---------------------------------------------------------- >>> >>> Key: WHIRR-398 >>> URL: https://issues.apache.org/jira/browse/WHIRR-398 >>> Project: Whirr >>> Issue Type: New Feature >>> Components: core >>> Reporter: David Alves >>> Assignee: David Alves >>> Fix For: 0.7.0 >>> >>> Attachments: WHIRR-398-unit-test-with-log-dry-run.patch, >> WHIRR-398.patch, WHIRR-398.patch, WHIRR-398.patch, WHIRR-398.patch, >> WHIRR-398.patch >>> >>> >>> beforeDestroy() method in ClusterActionHandlerSupport does nothing and >> is misleading. >>> Besides doing something on cluster shutdown can be really handy. >> >> -- >> This message is automatically generated by JIRA. >> If you think it was sent incorrectly, please contact your JIRA >> administrators: >> https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa >> For more information on JIRA, see: http://www.atlassian.com/software/jira >> >> >>
