Hi Andrei, I did not run the tests but did a code review. What I can see it looks great. So as long as the tests pass for you I am +1.
Lars On Jan 24, 2012, at 6:16 AM, Andrei Savu wrote: > Anyone has some time to review them? > > On Sat, Jan 21, 2012 at 2:25 AM, Andrei Savu <[email protected]> wrote: > >> Hey guys, >> >> Here are two more patches awaiting a review: >> >> https://issues.apache.org/jira/browse/WHIRR-483 (just a version change) >> https://issues.apache.org/jira/browse/WHIRR-479 (a bit more complicated) >> >> Next thing for me is to work on Hadoop start / stop / cleanup scripts. >> >> Akash any updates on HBase? >> >> Cheers, >> >> -- Andrei Savu / andreisavu.ro >> >>
