[ 
https://issues.apache.org/jira/browse/WHIRR-465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205309#comment-13205309
 ] 

Andrei Savu commented on WHIRR-465:
-----------------------------------

Nice work! Here are some quick comments / questions:

* can we reference a specific Apache Solr 4.0 build? Or star a build? Deploying 
from snapshot can be brittle
* it should be possible to specify the .tar.gz URL
* we need an integration test to show that the service starts as expected 
(indexing a document? status page?)
* please generate the patch using "git diff --no-prefix trunk" or "svn diff"
* use getInstallFunction to get the name of the script for install_java 
* it would be nice to have an init script. See 
core/src/main/resources/functions/{install,remove}_service.sh
* as we have a start script now we should also have a config and a stop script
* we usually install services in /usr/local/

Let me know if I can help on the way. I'm available most of the time on IRC at 
#whirr (asavu)

                
> Add Solr as a service
> ---------------------
>
>                 Key: WHIRR-465
>                 URL: https://issues.apache.org/jira/browse/WHIRR-465
>             Project: Whirr
>          Issue Type: New Feature
>          Components: new service
>    Affects Versions: 0.8.0
>            Reporter: Andrei Savu
>            Assignee: David Arthur
>              Labels: feature, patch
>             Fix For: 0.9.0
>
>         Attachments: 0001-WHIRR-465-Adding-Solr-as-a-Whirr-service.patch
>
>
> http://lucene.apache.org/solr/

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to