[
https://issues.apache.org/jira/browse/WHIRR-604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13434111#comment-13434111
]
Tom White commented on WHIRR-604:
---------------------------------
This is a definite improvement over the current code, even if it's not Adrian's
more general approach. Adrian - are you OK with this approach for the time
being?
One small thing I noticed - the order of the arguments in the JUnit asserts is
wrong - it should be {{assertEquals(expected, actual)}}. Worth adding a message
too.
> Non-resolvable hostnames should be reset to something resolvable
> ----------------------------------------------------------------
>
> Key: WHIRR-604
> URL: https://issues.apache.org/jira/browse/WHIRR-604
> Project: Whirr
> Issue Type: Bug
> Components: core
> Affects Versions: 0.7.1
> Reporter: Andrew Bayer
> Assignee: Adrian Cole
> Fix For: 0.8.0
>
> Attachments: WHIRR-604.patch, WHIRR-604.patch, WHIRR-604.patch
>
>
> So we currently have a hack in
> core/src/main/resources/functions/configure_hostnames.sh to reset the
> instance hostname on Rackspace to a-b-c-d.static.cloud-ips.com, since the
> hostname on the instance that Rackspace uses either isn't resolvable at all
> or isn't resolvable externally (not 100% sure which is the case there - I
> think they're just not resolvable). This logic should be generalized, since
> there are other providers where this is the case, and it's also an issue
> with, say, something like a private Cloudstack install.
> What seems to make sense is to add a property - something like
> whirr.ip-hostname-domain - and to add a check if we can actually resolve the
> instance's hostname from anywhere but that particular instance (since the
> very fact of it being in /etc/hostname means it'll be resolvable locally). If
> not, set the hostname to a-b-c-d.${whirr.ip-hostname-domain}, with logic in
> Java somewhere to have a mapping of known provider->ip hostname domains for
> cases like Rackspace, so that whirr.ip-hostname-domain doesn't need to be set
> explicitly in those cases.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
