[ 
https://issues.apache.org/jira/browse/WHIRR-649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13449120#comment-13449120
 ] 

Graham Gear commented on WHIRR-649:
-----------------------------------

I also note, that since a install_hadoop invoked install_cdh_hadoop script 
includes a tarball paramater, it qualifies as not equal to a parameterless 
install_cdh_hadoop statement and therefore results in 2 invocations of this 
function, Eg:

{code:title=bootstrap-*.sh|borderStyle=solid}
install_oab_java || exit 1

install_cdh_hadoop -u 
http://apache.osuosl.org/hadoop/common/hadoop-0.20.205.0/hadoop-0.20.205.0.tar.gz
 || exit 1

install_cdh_hadoop || exit 1

install_cm || exit 1
{code}

This patch protects against running this function twice, although there is a 
bit of code smell around this.
                
> Make install_cdh_hadoop.sh idempotent, fast failing if already run
> ------------------------------------------------------------------
>
>                 Key: WHIRR-649
>                 URL: https://issues.apache.org/jira/browse/WHIRR-649
>             Project: Whirr
>          Issue Type: Improvement
>    Affects Versions: 0.7.1
>            Reporter: Graham Gear
>         Attachments: WHIRR-649.patch
>
>
> Currently, install_cdh_hadoop.sh does not check it has already run and 
> return, unlike install_hadoop.sh.
> This is inefficient for services that would like to install CDH components 
> which have often already been installed (eg Cloudera Manager).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to