[
https://issues.apache.org/jira/browse/WHIRR-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13486503#comment-13486503
]
Graham Gear commented on WHIRR-671:
-----------------------------------
Attached new patch impl:
https://issues.apache.org/jira/secure/attachment/12551276/WHIRR-671-VERSION-02.patch
addressing issues raised:
* Adding new services should not usually require a change to core. In this case
the Kerberos realm has been added to the cluster spec class. I wonder if
there's a way to avoid that, e.g. with whirr.env properties?
The Kerberos realm could be provided as a whirr.env variable, but I thought it
significant enough to warrant its own cluster spec field since it is a cross
cutting concern (multiple modules are likely to use it, eg kerberos, whirr-cm,
etc) and the additional meta-data (eg description, type) self document the
important property. Having said that, I am happy to drop the cluster spec field
in favour of whirr.env if we think we should?
* Typo: "secuirty"
Fixed
* KerberosBaseHandler has an empty catch block (needs a comment at least), and
the if statement should have braces.
Fixed
> Create Kerberos Service
> -----------------------
>
> Key: WHIRR-671
> URL: https://issues.apache.org/jira/browse/WHIRR-671
> Project: Whirr
> Issue Type: New Feature
> Components: new service
> Reporter: Graham Gear
> Assignee: Graham Gear
> Priority: Minor
> Attachments: WHIRR-671-VERSION-01.patch, WHIRR-671-VERSION-02.patch
>
>
> Create a Kerberos service providing KDC and client provisioning profiles
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
