and that is good! we just need to run the formatter once on the entire
codebase and from then on everything should be in sync.


-igor


On 9/3/07, Matej Knopp <[EMAIL PROTECTED]> wrote:
>
> Well, for some reason wicket is setup that it reformats source code on
> every
> save by default.
>
> -Matej
>
> On 9/3/07, Jean-Baptiste Quenot <[EMAIL PROTECTED]> wrote:
> >
> > * [EMAIL PROTECTED]:
> > > Author: ehillenius
> > > Date: Tue Aug 28 14:19:53 2007
> > > New Revision: 570573
> > >
> > > URL: http://svn.apache.org/viewvc?rev=570573&view=rev
> > > Log:
> > > better exception
> > >
> > > Modified:
> > >     wicket/trunk/jdk-1.4
> >
> /wicket/src/main/java/org/apache/wicket/protocol/http/request/WebRequestCodingStrategy.java
> > >
> > > Modified: wicket/trunk/jdk-1.4
> >
> /wicket/src/main/java/org/apache/wicket/protocol/http/request/WebRequestCodingStrategy.java
> > > URL:
> >
> http://svn.apache.org/viewvc/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/protocol/http/request/WebRequestCodingStrategy.java?rev=570573&r1=570572&r2=570573&view=diff
> > >
> >
> ==============================================================================
> >
> > Snipping 350 lines of diff...
> >
> > Can you please, please avoid to reformat the classes everytime you
> > make a change?  That makes it impossible to review your
> > modification.
> >
> > If you really want the sources to have consistent formatting,
> > please do it in a separate commit, possibly in a batch.
> >
> > Thanks in advance,
> > --
> >      Jean-Baptiste Quenot
> > aka  John Banana   Qwerty
> > http://caraldi.com/jbq/
> >
>

Reply via email to