Hi,

2 suggestions :
* move Start.java and jetty dependencies to the scope "test", it's not part of 
the main application, it is only provide to allow developer to start an embedded 
webserver from IDE for *test*
* for the same goal (running from IDE), I use winstone-lite instead of jetty (lighter : 1 jar 166KB). But for running from CLI I use "mvn jetty:run" and the plugin manage its dependencies without me (not part of the project dependencies)

my 2 cents.

/david

Martijn Dashorst wrote:
According to my experiments, jetty doesn't start up without the
jetty-management dependency. Did you try it before removing?

Martijn

On 9/10/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote:
Author: ehillenius
Date: Sun Sep  9 17:30:36 2007
New Revision: 574108

URL: http://svn.apache.org/viewvc?rev=574108&view=rev
Log:
jetty-management is only needed for jmx. As quickstart doesn't (and shouldn't) 
include a reference to wicket-jmx, we better remove it.

Modified:
    wicket/trunk/jdk-1.4/wicket-quickstart/pom.xml
    
wicket/trunk/jdk-1.4/wicket-quickstart/src/main/java/org/apache/wicket/quickstart/Start.java

Modified: wicket/trunk/jdk-1.4/wicket-quickstart/pom.xml
URL: 
http://svn.apache.org/viewvc/wicket/trunk/jdk-1.4/wicket-quickstart/pom.xml?rev=574108&r1=574107&r2=574108&view=diff
==============================================================================
--- wicket/trunk/jdk-1.4/wicket-quickstart/pom.xml (original)
+++ wicket/trunk/jdk-1.4/wicket-quickstart/pom.xml Sun Sep  9 17:30:36 2007
@@ -51,10 +51,6 @@
                        <artifactId>jetty-util</artifactId>
                </dependency>
                <dependency>
-                       <groupId>org.mortbay.jetty</groupId>
-                       <artifactId>jetty-management</artifactId>
-               </dependency>
-               <dependency>
                        <groupId>org.slf4j</groupId>
                        <artifactId>slf4j-log4j12</artifactId>
                </dependency>

Modified: 
wicket/trunk/jdk-1.4/wicket-quickstart/src/main/java/org/apache/wicket/quickstart/Start.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/jdk-1.4/wicket-quickstart/src/main/java/org/apache/wicket/quickstart/Start.java?rev=574108&r1=574107&r2=574108&view=diff
==============================================================================
--- 
wicket/trunk/jdk-1.4/wicket-quickstart/src/main/java/org/apache/wicket/quickstart/Start.java
 (original)
+++ 
wicket/trunk/jdk-1.4/wicket-quickstart/src/main/java/org/apache/wicket/quickstart/Start.java
 Sun Sep  9 17:30:36 2007
@@ -58,12 +58,6 @@
                web.setWar("src/main/webapp");
                server.addHandler(web);

-               // uncomment this to enable JMX (need Java 5)
-               // MBeanServer mBeanServer = 
ManagementFactory.getPlatformMBeanServer();
-               // MBeanContainer mBeanContainer = new 
MBeanContainer(mBeanServer);
-               // server.getContainer().addEventListener(mBeanContainer);
-               // mBeanContainer.start();
-
                try
                {
                        server.start();





Reply via email to