Al Maw wrote:
Gwyn Evans wrote:
On Thursday, September 20, 2007, 11:28:02 AM, Martijn
<[EMAIL PROTECTED]> wrote:
I would feel more confident in the outcome when Al has had his looksy
on sunday. Shall we at least extend the vote until then? Typical votes
run for 72 hours, so it wouldn't delay too much if we extend it until
sunday evening or so. If Al hasn't been able to check it on sunday, I
don't see a reason for further delay though.
No problem with extending here, I just felt that as the discussion had
dried up, even pending Al's review it would be worth trying to get an
idea of the feelings either way sooner rather than later.
I'll try to do a review later tonight. I've had a quick look, and it's
all good so far... ;-)
Hi Al,
I don't know if you already did look deeper into it, but I discovered I missed encoding "ignoreIfNotActive=true" for an IActivePageBehavior.LISTENER in
UrlCompressingWebCodingStrategy.
I'll commit an update to the 1.3.0-beta3-portlet-support branch shortly and
will later also provide an updated overall patch for WICKET-983.
Furthermore, I think I have a somewhat cleaner solution for WICKET-926: Support
for detached/popup pages.
I'm still working on it, but I expect to have an update for that ready soon too.
And FYI: in (hopeful) anticipation of the merge to trunk, I've already done
this locally, so I'm now testing against the trunk myself already :)
And to my pleasant surprise, the latest changes to BrowserInfoPage.continueToPrevious() and WebRequestCycle.newClientInfo() are now already portlet compliant so
my changes for those are no longer needed.
So if you're still need to review, you can ignore those!
Regards,
Ate
Regards,
Al
