Hi,

I think that I found a bug in the LocalizedImageResource class.
If you use the Image component, and some parent of it returns
a different variation, then the ResourceReference returned by
overriding the getImageResourceReference() won't be used.

This is because in LocalizedImageResource, the style of the Image
component (which is the combination of session.getStyle() and
the variation) is stored in the LocalizedImageResource class.
But when the Image is created, it doesn't have a parent so it
can't really trust the result of getStyle(). Because when I add
the image to some parent which has a different variation, the
style changes and the resource reference cached in
LocalizedImageResource gets reset.

This behavior worked before revision 579325. Around line 250, the
line:

 if (resourceKind == null &&

changed to:

 if (resourceKind == null ||

which causes the style to be tested. If I provide an image resource
trough a model, everything works fine. Because after it resets the
cached image resource (because the style changed) it will check the
model for any resource reference.

Is this a bug, or am I not supposed to override getImageResource()
on the image component?

Thanks,
Bart.

Reply via email to