Johan has fixed the code and the tests. However, he assured me that the test failure shouldn't cause problems in application code.
I'm changing my vote to -1. I think shipping a release candidate with a test failure gives the wrong impression. Though the failures don't occur on most machines, I think we should take the high road and rebuild the release with the patch in. The patch can be taken from head and applied to the release branch. The release can then be recreated and the vote restarted. Martijn On 11/5/07, Martijn Dashorst <[EMAIL PROTECTED]> wrote: > I've taken some time to test the release, but I get the following test > failure on OS X, Java 4: > > [surefire] Running org.apache.wicket.markup.html.image.ImageTest > [surefire] Tests run: 1, Failures: 1, Errors: 0, Time elapsed: 0.037 > sec <<<<<<<< FAILURE !! > > So that would be a -1? > > Martijn > > On 11/5/07, Martijn Dashorst <[EMAIL PROTECTED]> wrote: > > +0 (I don't have the time to test the release, but don't want to hold it > > back). > > > > The release does have your signature, so that's cool (just need to > > verify you are actually you). > > > > Martijn > > > > On 11/4/07, Frank Bille <[EMAIL PROTECTED]> wrote: > > > Hi all, > > > > > > I have uploaded the artifacts to my p.a.o account. This is what I have > > > tested: > > > > > > * Run "mvn clean install" on the distribution. Installs, no test failures. > > > * Run RAT[1] on the release and checked the output. Nothing to notice. > > > * Tried different things in the examples, like ajax, links, images, forms, > > > guice and pub2. Nothing to notice. > > > > > > The releases has been signed with my GPG key, which you can find in the > > > KEYS[2] file. It's still not signed by anyone (lazy me) > > > > > > Anyway, here you can find the distribution files: > > > http://people.apache.org/~frankbille/releases/apache-wicket-1.3.0-rc1/dist/ > > > <http://people.apache.org/%7Efrankbille/releases/apache-wicket-1.3.0-rc1/dist/> > > > > > > and here you can find the maven repo: > > > http://people.apache.org/~frankbille/releases/apache-wicket-1.3.0-rc1/m2-repo/<http://people.apache.org/%7Efrankbille/releases/apache-wicket-1.3.0-rc1/m2-repo/> > > > > > > and here I have uploaded the RAT logs: > > > http://people.apache.org/~frankbille/releases/apache-wicket-1.3.0-rc1/<http://people.apache.org/%7Efrankbille/releases/apache-wicket-1.3.0-rc1/> > > > > > > [ ] Release Apache Wicket 1.3.0-rc1 > > > [ ] Don't release, because... > > > > > > > > > Regards > > > Frank > > > > > > > > > [1]: http://code.google.com/p/arat/ > > > [2]: http://svn.apache.org/repos/asf/wicket/common/KEYS > > > > > > > > > -- > > Buy Wicket in Action: http://manning.com/dashorst > > Apache Wicket 1.3.0-beta4 is released > > Get it now: http://www.apache.org/dyn/closer.cgi/wicket/1.3.0-beta4/ > > > > > -- > Buy Wicket in Action: http://manning.com/dashorst > Apache Wicket 1.3.0-beta4 is released > Get it now: http://www.apache.org/dyn/closer.cgi/wicket/1.3.0-beta4/ > -- Buy Wicket in Action: http://manning.com/dashorst Apache Wicket 1.3.0-beta4 is released Get it now: http://www.apache.org/dyn/closer.cgi/wicket/1.3.0-beta4/
