Yeah, for setMetaData. But will that work for getMetaData as well? -Matej
On Feb 18, 2008 11:11 PM, Martijn Dashorst <[EMAIL PROTECTED]> wrote: > The adapters you have provided should maintain binary compatibility, don't > they? > > Martijn > > > On 2/18/08, Matej Knopp <[EMAIL PROTECTED]> wrote: > > Hi, > > > > I've changed the RequestCycle.set/getMetadata as well as > > Application.set/getMetadata methods to take Object instead of > > serializable. It doesn't make sense to require serializable arguments > > for this data, that's the purpose of storing things in request cycle. > > Unfortunately this breaks the binary compatibility as method signature > > changes (I didn't realize this when committing). > > > > Now the question is? Should I revert it? I know we try to maintain > > binary compatibility between releases. On the other hand, this is a > > rather small change and IMHO won't influence the vast majority of > > users. > > > > Anyway, I'm prepared to revert it, if others think i should. > > > > -Matej > > > > > -- > Buy Wicket in Action: http://manning.com/dashorst > Apache Wicket 1.3.1 is released > Get it now: http://www.apache.org/dyn/closer.cgi/wicket/1.3.1 > -- Resizable and reorderable grid components. http://www.inmethod.com
