hmm for 1.3 i will test it that i will always just give a cloned version Then we can keep the map and the method just fine.
That fix is fine by me then johan On Sun, Mar 23, 2008 at 6:48 PM, James Carman <[EMAIL PROTECTED]> wrote: > NumberFormat objects are cloneable. So, maybe you could use the > format passed in to setNumberFormat() as a "prototype" to create one > for the current thread/invocation (I don't know if you use thread > locals for this or not)? > > On Sun, Mar 23, 2008 at 11:43 AM, Johan Compagner <[EMAIL PROTECTED]> > wrote: > > I was looking to fix this issue: > > https://issues.apache.org/jira/browse/WICKET-1421 > > > > and then i came across AbstractDecimalConverter which still caches > Format > > objects > > Those are not thread safe so we should really remove those. > > The problem is then we also have to remove > setNumberFormat(LocalemFormat) > > method > > and that is an API break. (That method could be used if you as > developer > > know for SURE that the converter is used in 1 thread at a time) > > Much better would be to override getNumberFormat() and return what > every you > > want for that locale, so that method can have bad consequents to use > anyway. > > so again: > > > > [] remove the map and the method for 1.3 > > [] remove the map and the method for 1.4 > > > > johan > > >
