i've never experienced that. but i like the code style idea... Gerolf
On Fri, May 9, 2008 at 11:31 AM, Johan Compagner <[EMAIL PROTECTED]> wrote: > really? > is the maven eclipse plugin tampering with my project settings!!?? > > > > On Fri, May 9, 2008 at 11:28 AM, Maurice Marrink <[EMAIL PROTECTED]> > wrote: > > > Maven eclipse plugin can sometimes mess with the settings but now they > > have this new feature > > > > > http://maven.apache.org/plugins/maven-eclipse-plugin/examples/load-code-styles.html > > I have not used this yet and i don't think it supports warnings and > > error messages too, but this way we can remove the codestyle from svn > > for each project and instead have one codestyle file in the parent > > project. > > > > Maurice > > > > On Fri, May 9, 2008 at 11:10 AM, Johan Compagner <[EMAIL PROTECTED]> > > wrote: > > > make a jira issue for that patch > > > else it will be lost. > > > > > > Did eclipse report those errors? > > > Because that would be strange, why dont i have those problems.. You > > should > > > use the project settings > > > Maybe those are not completely correct then and need some more tuning > > > > > > > > > On Fri, May 9, 2008 at 9:19 AM, Jeremy Thomerson < > > [EMAIL PROTECTED]> > > > wrote: > > > > > >> Well, I'm not sure exactly why the settings are in SVN... I assumed to > > keep > > >> everyone on the same page, but obviously most developers are > overriding > > >> them > > >> (or their IDE would bother them with compile errors like mine does). > > >> > > >> If one of the committers wants to commit the following patch, new devs > > can > > >> checkout the source, do mvn eclipse:eclipse like normal, and be up and > > >> running with no compile errors. > > >> > > >> http://pastebin.com/m3d0b07b3 > > >> > > >> Jeremy Thomerson > > >> http://www.wickettraining.com > > >> > > >> On Tue, May 6, 2008 at 8:50 AM, Johan Compagner <[EMAIL PROTECTED] > > > > >> wrote: > > >> > > >> > i dont think so those .settings dirs should take care of that. > > >> > > > >> > On Tue, May 6, 2008 at 3:46 PM, Jeremy Thomerson < > > >> > [EMAIL PROTECTED]> > > >> > wrote: > > >> > > > >> > > The eclipse settings look to be more for code style enforcement - > to > > >> make > > >> > > sure everyone uses the same standards. But, obviously they are > > >> > overridden > > >> > > or something on some machines.... > > >> > > > > >> > > Jeremy > > >> > > > > >> > > On Tue, May 6, 2008 at 8:45 AM, James Carman < > > >> [EMAIL PROTECTED] > > >> > > > > >> > > wrote: > > >> > > > > >> > > > Should there really be Eclipse settings in the SVN repo? You > can > > >> > > > simply do mvn eclipse:eclipse to set up Eclipse. Yes, I realize > > that > > >> > > > not everyone uses Maven, but if they're going to try to > > view/develop > > >> > > > Wicket, then they should be. The eclipse settings can get out > of > > >> sync > > >> > > > with the pom.xml file, right? > > >> > > > > > >> > > > On Tue, May 6, 2008 at 9:41 AM, Jeremy Thomerson > > >> > > > <[EMAIL PROTECTED]> wrote: > > >> > > > > Up to date? If you mean svn update - yes. There are > obviously > > >> newer > > >> > > > > version of java around, but that's what I run on production, > so > > >> > > that's > > >> > > > what > > >> > > > > I run locally. > > >> > > > > > > >> > > > > It's very strange to me because it works in Eclipse, and I > have > > >> > > Eclipse > > >> > > > set > > >> > > > > to use the same JVM. > > >> > > > > > > >> > > > > I can fiddle with that and get by... Do you know about the > > other > > >> > > > question, > > >> > > > > though? If the Wicket team has committed Eclipse settings > that > > >> give > > >> > > an > > >> > > > > error for Serializable without serialVersionUID, why are > there > > >> seven > > >> > > > classes > > >> > > > > that don't have it (causing seven compile errors in my > > Eclipse)? > > >> > Can > > >> > > I > > >> > > > just > > >> > > > > submit a patch to add a serialVersionUID = 1L to each of > those? > > >> Or > > >> > > > what > > >> > > > > does everyone else do - override the Eclipse settings? > > >> > > > > > > >> > > > > Thanks for all your help! > > >> > > > > Jeremy > > >> > > > > > > >> > > > > On Tue, May 6, 2008 at 8:34 AM, Martijn Dashorst < > > >> > > > [EMAIL PROTECTED]> > > >> > > > > wrote: > > >> > > > > > > >> > > > > > > >> > > > > > > >> > > > > > On 5/6/08, Jeremy Thomerson <[EMAIL PROTECTED]> > > wrote: > > >> > > > > > > No - it's using: > > >> > > > > > > > > >> > > > > > > java version "1.5.0_13" > > >> > > > > > > Java(TM) 2 Runtime Environment, Standard Edition (build > > >> > > > 1.5.0_13-b05) > > >> > > > > > > Java HotSpot(TM) Server VM (build 1.5.0_13-b05, mixed > > mode) > > >> > > > > > > > >> > > > > > Strange. Teamcity runs the build using maven as well and > none > > of > > >> > > the > > >> > > > > > tests fail (currently). Perhaps a version conflict in > maven? > > Or > > >> > > > > > otherwise it could be a platform difference, endlines > perhaps > > >> (but > > >> > > > > > then I'd expect more tests to fail) > > >> > > > > > > > >> > > > > > Are you up to date? > > >> > > > > > > > >> > > > > > Martijn > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > >> > > >> > > >> -- > > >> Jeremy Thomerson > > >> http://www.wickettraining.com > > >> > > > > > >
