Hi, Thanks for your answer.
I admit the EnumDropDownChoice is more of a convenient class that a real new feature. However, it has the benefit of providing its enclosed EnumChoiceRenderer a base component to call getString() on. A standalone EnumChoiceRenderer would need to take a Component as a constructor parameter, to call getString() on, and I thought it might be a bit confusing for the developers. Now, if everyone finds it better, I am willing to submit a new patch with only the EnumChoiceRenderer, modified as required. On the other hand, any remarks on the EnumMessageKeyProvider system ? Olivier On Wed, Nov 11, 2009 at 7:58 PM, Martin Makundi < martin.maku...@koodaripalvelut.com> wrote: > I vote for EnumChoiceRender instead of full DropDownChoice. > > However. EnumChoiceRenderer can render any TYPE so that's why I have > proposed TypeChoiceRenderer. You can directly use it with existing > wicket and no need for specific dropdown. > > ** > Martin > > 2009/11/11 Olivier Croisier <olivier.crois...@gmail.com>: > > Hi, > > > > I just submitted a patch to the very old > > WICKET-1157<https://issues.apache.org/jira/browse/WICKET-1157>JIRA (no > > activity for the last 2 years). > > It provides a simple and flexible way to internationalize enums : > > - An EnumMessageKeyProvided that implements a Strategy pattern to > generate > > I18N keys from enums. > > - An EnumDropDownChoice to render HTML <select> components > > - An EnumModel to internationalize any enum provided by another Model (so > > there is no need of EnumLabels and such). > > > > Hope that helps, > > > > Olivier > > >
