Well, I'd say that it would be better to think this thing through a bit better and come up with a solution (like the executor idea that was proposed earlier) that actually works the way users would expect it to all the time. To me, releasing with something that we know is half-baked at best is a mistake.
On Thu, May 20, 2010 at 6:17 PM, Jeremy Thomerson <jer...@wickettraining.com> wrote: > +1 - Yes, release. > > I understand that some don't like this because of the > InheritableThreadLocal. But, I have not seen anything that proves that it > will cause a bug. It's my understanding that it: > > - does work for the one hedge case that it was requested for (starting > short-lived threads from the request thread) > - does not break other things (if you are using pooled executors, etc) > - does not add any extra complexity to our codebase > > In that case, I'm in favor of leaving it. However, considering the very > slight value that it adds, if someone conclusively proves that it breaks > existing applications (that are not doing something stupid), then I am in > favor of reverting it for the next release. It just does not have any > proven detrimental effects that should delay this release and the benefits > of the other fixes / enhancements. > > -- > Jeremy Thomerson > http://www.wickettraining.com > > > > On Wed, May 19, 2010 at 2:35 AM, Jeremy Thomerson <jer...@wickettraining.com >> wrote: > >> This vote is to release wicket 1.4.9 >> >> Branch: http://svn.apache.org/repos/asf/wicket/branches/wicket-1.4.9/ >> Artifacts: >> http://people.apache.org/~jrthomerson/releases/apache-wicket-1.4.9/dist >> Maven repo: >> http://people.apache.org/~jrthomerson/releases/apache-wicket-1.4.9/m2-repo >> Changelog: >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310561&styleName=Html&version=12314962 >> (and below) >> >> This vote ends Saturday 2:30am GMT-5 >> >> Please test the release and offer your vote: >> [ ] Yes, release >> [ ] No, don't release it (and please tell us why) >> >> -- >> Jeremy Thomerson >> http://www.wickettraining.com >> >> --------- >> >> Release Notes - Wicket - Version 1.4.9 >> >> ** Bug >> * [WICKET-2741] - non-performant Collections.synchronizedMap() should >> be replaced with ConcurrentMap >> * [WICKET-2843] - Palette is incompatible with ListMultipleChoice in >> its use of the model >> * [WICKET-2853] - ListMultipleChoice/CheckBoxMultipleChoice do not >> retain selected but disabled items >> * [WICKET-2856] - PackageStringResourceLoader.loadStringResource() >> causes NullPointerException when used in a Class within the root package >> (i.e. it has no package declaration) >> * [WICKET-2858] - WicketSessionFilter: >> java.lang.IllegalArgumentException: Argument application can not be null >> * [WICKET-2859] - Wrong package names in Examples >> * [WICKET-2860] - Wrong name for swiss Application.properties >> * [WICKET-2861] - getConvertedInput() returns null and >> selectedValues.addAll tries adding it >> >> ** Improvement >> * [WICKET-2790] - wicketTester.executeAjaxEvent method does not check >> if form is multiPart >> * [WICKET-2840] - Remove final on >> AbstractRequestTargetUrlCodingStrategy#getMountPath() >> * [WICKET-2846] - Store Application in InheritableThreadLocal instead >> of ThreadLocal >> * [WICKET-2855] - Constructor of RedirectRequestTarget does not >> validate URL >> * [WICKET-2869] - RangeValidator should use getMinimum and getMaximum >> * [WICKET-2870] - Fix hungarian translation for Wizard >> * [WICKET-2879] - delegate isVisible in PanelCachingTab >> >> >> >> >
