On Tue, Jul 20, 2010 at 8:38 PM, Martin Grigorov <martin.grigo...@gmail.com> wrote: > Two commets from me: > - the test is broken ;-) (I'll fix it right away)
Didn't think it was tested... > - the change is not very i18n friendly, but at least it is easy to extend I thought about that but it would only show up when someone doesn't see the image... So the impact is negligible... Martijn > > 2010/7/20 <dasho...@apache.org> > >> Author: dashorst >> Date: Tue Jul 20 10:28:46 2010 >> New Revision: 965786 >> >> URL: http://svn.apache.org/viewvc?rev=965786&view=rev >> Log: >> Fixes WICKET-2951 >> >> Modified: >> >> wicket/branches/wicket-1.4.x/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/AjaxLazyLoadPanel.java >> >> Modified: >> wicket/branches/wicket-1.4.x/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/AjaxLazyLoadPanel.java >> URL: >> http://svn.apache.org/viewvc/wicket/branches/wicket-1.4.x/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/AjaxLazyLoadPanel.java?rev=965786&r1=965785&r2=965786&view=diff >> >> ============================================================================== >> --- >> wicket/branches/wicket-1.4.x/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/AjaxLazyLoadPanel.java >> (original) >> +++ >> wicket/branches/wicket-1.4.x/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/AjaxLazyLoadPanel.java >> Tue Jul 20 10:28:46 2010 >> @@ -151,7 +151,7 @@ public abstract class AjaxLazyLoadPanel >> */ >> public Component getLoadingComponent(final String markupId) >> { >> - return new Label(markupId, "<img src=\"" + >> + return new Label(markupId, "<img alt=\"Loading...\" src=\"" >> + >> >> RequestCycle.get().urlFor(AbstractDefaultAjaxBehavior.INDICATOR) + >> "\"/>").setEscapeModelStrings(false); >> } >> >> >> >> > -- Become a Wicket expert, learn from the best: http://wicketinaction.com Apache Wicket 1.4 increases type safety for web applications Get it now: http://www.apache.org/dyn/closer.cgi/wicket/1.4.8
