Usage of Session

[Martin Grigorov]

Hi,

While working on https://issues.apache.org/jira/browse/WICKET-3477 I found
this usages of Session:

Index: wicket-core/src/main/java/org/apache/wicket/Application.java
===================================================================
--- wicket-core/src/main/java/org/apache/wicket/Application.java (revision
1073297)
+++ wicket-core/src/main/java/org/apache/wicket/Application.java (working
copy)
@@ -273,13 +273,14 @@
  {
  final Class<? extends Component> cl = component.getClass();
  // If component instantiation is not authorized
- if
(!Session.get().getAuthorizationStrategy().isInstantiationAuthorized(cl))
- {
+ if
(!getSecuritySettings().getAuthorizationStrategy().isInstantiationAuthorized(cl))
  // then call any unauthorized component instantiation
  // listener
  getSecuritySettings().getUnauthorizedComponentInstantiationListener()
  .onUnauthorizedInstantiation(component);
  }
  });
  }
Index: wicket-core/src/main/java/org/apache/wicket/Page.java
===================================================================
--- wicket-core/src/main/java/org/apache/wicket/Page.java (revision 1073297)
+++ wicket-core/src/main/java/org/apache/wicket/Page.java (working copy)
@@ -33,7 +33,6 @@
 import org.apache.wicket.markup.html.WebPage;
 import org.apache.wicket.markup.resolver.IComponentResolver;
 import org.apache.wicket.model.IModel;
-import org.apache.wicket.page.IManageablePage;
 import org.apache.wicket.page.IPageManager;
 import org.apache.wicket.pageStore.IPageStore;
 import org.apache.wicket.request.component.IRequestablePage;
@@ -364,7 +360,7 @@
  return;
  }

- final IPageManager pageManager = getSession().getPageManager();
+ final IPageManager pageManager = getApplication().getPageManager();
  if (!getFlag(FLAG_IS_DIRTY) && isVersioned() &&
pageManager.supportsVersioning())
  {
  setFlag(FLAG_IS_DIRTY, true);


Is it really needed this indirection to get the Application thru the Session
 ?