Currently to make the UploadProgressbar component working one has to use a
special request in the wicket application. This can be seen
in o.a.w.examples.upload.UploadApplication.newWebRequest:
@Override
protected WebRequest newWebRequest(HttpServletRequest servletRequest, String
filterPath)
{
return new UploadWebRequest(servletRequest, filterPath);
}It seems a bit heavyweight to me to use a special wicket request for every web request just to make a component working. UploadWebRequest and MultipartRequest (both in extensions) do not add much to their supperclasses: ServletWebRequest and MultipartServletWebRequestImpl (both in core). Even most of the upload progress updating logic is already in MultipartServletWebRequestImpl. So: wouldn't it be better to merge UploadWebRequest and MultipartRequest into their superclasses? The need for monitoring is currently decided in MultipartServletWebRequestImpl.wantUploadProgressUpdates(). By default that could come from an IApplicationSettings option. Attila
