not sure why keep AA around once AM can do the job... -igor
On Thu, Jun 9, 2011 at 10:28 AM, Martin Grigorov <[email protected]> wrote: > AA is not, SAM is deprecated. > > On Thu, Jun 9, 2011 at 7:23 PM, Clint Checketts <[email protected]> wrote: >> So AttributeAppender and SimpleAttributeModifier will not be deprecated? >> >> On Thu, Jun 9, 2011 at 10:24 AM, Martijn Dashorst < >> [email protected]> wrote: >> >>> I've committed the rework for 1.5, which doesn't completely rework >>> AttirubteModifier and friends, but sets the stage for 1.6. I didn't >>> want to break too much API this late in 1.5 >>> >>> See: WICKET-3783 for details. >>> >>> Martijn >>> >>> On Thu, Jun 9, 2011 at 5:23 PM, Martijn Dashorst >>> <[email protected]> wrote: >>> > In short: AttributeModifier can get a lot simpler: >>> > - always add the attribute (unless the AM is disabled) >>> > - the regexp matching functionality needs to go >>> > - replaceModel needs to become an Object (with instanceof check for >>> models) >>> > - enabled field should be removed in favor of subclassing and >>> > overriding isEnabled() >>> > >>> > This will clean up AttributeModifier considerably—not catering for >>> > extreme use cases. >>> > >>> > Martijn >>> > >>> >>> >>> >>> -- >>> Become a Wicket expert, learn from the best: http://wicketinaction.com >>> >> > > > > -- > Martin Grigorov > jWeekend > Training, Consulting, Development > http://jWeekend.com >
