GitHub user jesselong opened a pull request:
https://github.com/apache/wicket/pull/8
Some small changes to wicket 6
* Logging to SLF4j instead of System.err
* Remove DateConverter#get/setComponent() and DateConverter#getLocale()
DateConverter#getLocale() was protected and never used - pointless.
DateConverter#get/setComponent() was used only by
DateConverter#getLocale()
This helps prevent DateLabel and DateTextField from leaking this from
the contructor.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jesselong/wicket for-apache-master-pr-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/wicket/pull/8.patch
----
commit a53c48ac6d9122baa90f1bbd1e86f40d34fd4093
Author: Jesse Long <[email protected]>
Date: 2012-05-09T08:57:52-07:00
Log exceptions to SLF4J
commit 04185aebcd486ac04c7498cd0517a7248b46ab35
Author: Jesse Long <[email protected]>
Date: 2012-05-09T09:02:29-07:00
Log exceptions to SLF4J, not stdout
commit 888698fb895c8df73a92a3beb0b3383b2e6deb71
Author: Jesse Long <[email protected]>
Date: 2012-05-09T09:24:04-07:00
Remove DateConverter#get/setComponent() and DateConverter#getLocale()
DateConverter#getLocale() was protected and never used - pointless.
DateConverter#get/setComponent() was used only by DateConverter#getLocale()
This helps prevent DateLabel and DateTextField from leaking this from the
contructor.
----
