No problem. Was nice to see the discussions happening during that time :-) Martijn
On Mon, Sep 2, 2013 at 3:12 PM, Martin Grigorov <mgrigo...@apache.org> wrote: > Thanks for the reference! > > > On Mon, Sep 2, 2013 at 4:00 PM, Martijn Dashorst <martijn.dasho...@gmail.com >> wrote: > >> And originally my proposal for the thing: >> >> >> http://mail-archives.apache.org/mod_mbox/wicket-dev/200704.mbox/%3c918312fe0704090625j366102ccv313d709753e7a...@mail.gmail.com%3e >> >> Martijn >> >> >> On Mon, Sep 2, 2013 at 2:59 PM, Martijn Dashorst >> <martijn.dasho...@gmail.com> wrote: >> > >> http://mail-archives.apache.org/mod_mbox/wicket-dev/200704.mbox/%3cceb609d80704092135t4aa1e120re863d3369f3a6...@mail.gmail.com%3e >> > >> > On Mon, Sep 2, 2013 at 2:42 PM, Martin Grigorov <mgrigo...@apache.org> >> wrote: >> >> Hi, >> >> >> >> I'm looking at https://issues.apache.org/jira/browse/WICKET-5311 and >> the >> >> SCM history of AbstractSingleSelectChoice class and I've noticed: >> >> >> >> commit e3bd9d3d8a1103b0c69fe6301be7e95630ff1066 >> >> Author: Eelco Hillenius <ehillen...@apache.org> >> >> Date: Tue Apr 10 04:29:44 2007 +0000 >> >> >> >> rolled back deprecation of nullValid >> >> >> >> git-svn-id: >> >> >> https://svn.apache.org/repos/asf/incubator/wicket/branches/wicket-1.x@52701613f79535-47bb-0310-9956-ffa450edef68 >> >> >> >> >> >> which reverts a change where setNullValid(boolean nullValid) did >> >> setRequired(!nullValid). >> >> >> >> I cannot find any earlier commit or a ticket that explains the reason >> for >> >> the change neither in Git, nor at http://svn.apache.org/viewvc, nor at >> >> >> https://fisheye6.atlassian.com/browse/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/form/AbstractSingleSelectChoice.java >> >> . >> >> >> >> Does someone remember the discussion about this change ? >> > >> > >> > >> > -- >> > Become a Wicket expert, learn from the best: http://wicketinaction.com >> >> >> >> -- >> Become a Wicket expert, learn from the best: http://wicketinaction.com >> -- Become a Wicket expert, learn from the best: http://wicketinaction.com
