In wicket 6, this code also still is in experimental. The reason I ported it to Wicket 6, was to actually use it. wicket-cdi (the old module), is usable with 1.1, but not very optimal. One of the main problems with the old implementation is the amount of InjectionTargets created. The annoying warnings will probably be fixed in Weld ( https://issues.jboss.org/browse/WELD-1547), but the fact remains that InjectionTargets are very expensive to create and should be cached. Another thing I like about the new module is that it actually uses CDI, not just makes it available in Wicket. Also, the integration requires a lot less code in a container that uses Weld (like Wildfly).
I do agree that the code is far from ready. For example, I don't think entire packages should be ignored. Also, I don't like how settings like auto-conversations are injected. I do like that CDI is used for that, but I'd rather see a configuration object with a @Producer method for all settings at once. Having the code in wicket 6 allows me to work on these issues. I do not expect our current application to be ported to Wicket 7 any time soon, but we are migrating to CDI 1.1 on Wildfly. Best regards, Emond On Fri, Nov 8, 2013 at 10:10 PM, John Sarman <[email protected]> wrote: > +1 removal > > Never should have been merged into the 6 branch and not the 7 until there > is a consensus. > > > On Fri, Nov 8, 2013 at 4:07 PM, Igor Vaynberg <[email protected] > >wrote: > > > not sure why this was merged into 6.x but there are a lot of problems > > with this contribution as can be seen here [1]. > > > > i think this should be removed from at least the release branch. > > > > -igor > > > > [1] https://github.com/apache/wicket/pull/50#issuecomment-28063112 > > >
