This vote failed. I have re-rolled the release, see the new vote thread...
Martijn
On Thu, Feb 13, 2014 at 4:11 PM, Martin Grigorov <mgrigo...@apache.org>wrote:
> This vote is negative anyway because of the problem with the bound session
> after submitting statelessform.
>
> Now the question is whether to improve these problems before the next vote
> or leave it for 6.15.0.
> Our app has a problem that two different components have the same sequence
> number, so same markup id ("id"+sequence).
> I think the problem is WICKET-5473, so it should be fixed.
>
> The rest of the suggested improvements from 5508 are obvious problems but
> since no one complained about them I think they can wait for 6.15.0.
>
> Martin Grigorov
> Wicket Training and Consulting
>
>
> On Thu, Feb 13, 2014 at 4:02 PM, Emond Papegaaij <
> emond.papega...@topicus.nl
> > wrote:
>
> > These fields have been like this for ages, right? Something that does not
> > pose any problems for most users and is not a security risk, is not a
> > blocking issue IMHO. We can't postpone wicket releases until all issues
> are
> > solved, else we will never release. If something broke since 6.12 or 6.13
> > and affects many users, that would be a showstopper for the 6.14 release
> > for me.
> >
> > On Thursday 13 February 2014 15:55:54 Martin Grigorov wrote:
> > > The issues are listed at
> > https://issues.apache.org/jira/browse/WICKET-5508
> > >
> > > I am not 100% sure these improvements are really blockers for the
> > release.
> > >
> > > - #sequence and #pageId => AtomicInteger is an improvement
> > > - #locale and #style => AtomicReference is a bug but no one so far
> > > complained about such problem
> > > - #dirty and #sessionInvalidated => volatile is again bug without
> > complains
> > > so far
> > > - #dirty() to change the #dirty boolean flag for bound sessions. Maybe
> I
> > > should remove this from the suggested patch. Having a temporary
> > session and
> > > calling #setStyle("...") should bind the session, otherwise next
> request
> > > won't have the style. Same for locale and metadata, and attributes
> > > But #pageid and #sequence should not bind the session because they
> > are
> > > needed even for stateless pages
> > > (WICKET-5473<https://issues.apache.org/jira/browse/WICKET-5473>
> > > )
> > >
> > > Martin Grigorov
> > > Wicket Training and Consulting
> > >
> > > On Thu, Feb 13, 2014 at 3:33 PM, Michael Haitz
> > <michael.ha...@1und1.de>wrote:
> > > > [X] No, don't release Apache Wicket 6.14.0, because ...
> > > >
> > > > of https://issues.apache.org/jira/browse/WICKET-5473 and other
> > related
> > > >
> > > > issues to Session class.
> > > >
> > > > Am 13.02.2014 um 14:14 schrieb Martin Grigorov
> > <mgrigo...@apache.org>:
> > > > > I've tested:
> > > > > - our main app
> > > > > - WicketStuff (mvn clean test)
> > > > > - Wicket-Bootstrap
> > > > > - random Wicket-examples
> > > > >
> > > > > No other issues found
> > > > >
> > > > > Martin Grigorov
> > > > > Wicket Training and Consulting
> > > > >
> > > > >
> > > > > On Wed, Feb 12, 2014 at 2:57 PM, Martin Grigorov
> > <mgrigo...@apache.org
> > > > >
> > > > >wrote:
> > > > >> This is fixed.
> > > > >> I still have to check our main application with 6.14.0
> > > > >>
> > > > >> Martin Grigorov
> > > > >> Wicket Training and Consulting
> > > > >>
> > > > >>
> > > > >> On Wed, Feb 12, 2014 at 2:47 PM, Martin Grigorov
> > <mgrigo...@apache.org
> > > > >
> > > > >wrote:
> > > > >>> I'll move setStatelessHint(false) back to
> > > >
> > > > RequestCycle.setResponsePage()
> > > >
> > > > >>> Martin Grigorov
> > > > >>> Wicket Training and Consulting
> > > > >>>
> > > > >>> On Wed, Feb 12, 2014 at 2:22 PM, Sven Meier
> > <s...@meiers.net> wrote:
> > > > >>>> Damn, not every page passed to PageProvider is stateless:
> > > > >>>>
> > > > >>>> + if (pageProvider.hasPageInstance())
> > > > >>>> + {
> > > > >>>> + IRequestablePage page =
> > > > >>>> pageProvider.getPageInstance();
> > > > >>>> + if (page instanceof Page)
> > > > >>>> + {
> > > > >>>> + ((Page)
> > > > >>>> page).setStatelessHint(false);
> > > > >>>>
> > > > >>>> :(
> > > > >>>>
> > > > >>>> Sven
> > > > >>>>
> > > > >>>> On 02/12/2014 02:10 PM, Martin Grigorov wrote:
> > > > >>>>> [ X ] No, don't release Apache Wicket 6.14.0, because
> > submitting
> > > > >>>>> stateless
> > > > >>>>> form binds a session
> > > > >>>>>
> > > > >>>>> Martin Grigorov
> > > > >>>>> Wicket Training and Consulting
> > > > >>>>>
> > > > >>>>>
> > > > >>>>> On Wed, Feb 12, 2014 at 9:51 AM, Martijn Dashorst <
> > > > >>>>> martijn.dasho...@gmail.com> wrote:
> > > > >>>>>
> > > > >>>>> This is a vote to release Apache Wicket 6.14.0
> > > > >>>>>
> > > > >>>>>> Please download the source distributions found in our
> > staging area
> > > > >>>>>> linked below.
> > > > >>>>>>
> > > > >>>>>> I have included the signatures for both the source archives.
> > This
> > > >
> > > > vote
> > > >
> > > > >>>>>> lasts for 72 hours minimum.
> > > > >>>>>>
> > > > >>>>>> [ ] Yes, release Apache Wicket 6.14.0
> > > > >>>>>> [ ] No, don't release Apache Wicket 6.14.0, because ...
> > > > >>>>>>
> > > > >>>>>> Distributions, changelog, keys and signatures can be found
> > at:
> > > > >>>>>> https://dist.apache.org/repos/dist/dev/wicket/6.14.0
> > > > >>>>>>
> > > > >>>>>> Staging repository:
> > > > >>>>>>
> > > > >>>>>>
> > > > >>>>>> https://repository.apache.org/content/repositories/
> > > > >>>>>> orgapachewicket-1004/
> >
>
--
Become a Wicket expert, learn from the best: http://wicketinaction.com
