Hi Emond,

I see you have used javax.annotation.Nullable  at
https://github.com/apache/wicket/blob/master/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/EventFilter.java?source=c#L44

The tiny bit that bothers me is that the parameter is annotated to be able
to be null but then you use it directly without check for null. Should we
add the check or change the annotation with javax.annotation.Nonnull ?

While here - what is the purpose of #equals() override at
https://github.com/apache/wicket/blob/master/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/EventFilter.java?source=c#L52?
Same in org.apache.wicket.atmosphere.NoFilterPredicate

Martin Grigorov
Wicket Training and Consulting

Reply via email to