OK, I see now that this method has been introduced couple of days ago with 30323a5800834760bcc0fca25bea7f81a3fb0e6d. All is fine.
Martin Grigorov Wicket Training and Consulting On Wed, May 7, 2014 at 8:17 AM, Martin Grigorov <[email protected]>wrote: > Hi Andrea, > > I am going to revert this change later today unless you provide a good > explanation that this is not an API break. > > Martin Grigorov > Wicket Training and Consulting > > > On Mon, May 5, 2014 at 9:51 PM, Martin Grigorov <[email protected]>wrote: > >> Hi Andrea, >> >> This setter may not be needed but the change looks like an API break to >> me. >> clirr-maven-plugin doesn't break the build here but I cannot explain why >> at the moment. >> >> MountMapper is already deprecated in 7.x so I think this >> optimization/change is not really needed. >> >> Martin Grigorov >> Wicket Training and Consulting >> >> >> On Mon, May 5, 2014 at 5:25 PM, <[email protected]> wrote: >> >>> Repository: wicket >>> Updated Branches: >>> refs/heads/wicket-6.x 30323a580 -> 69234c511 >>> >>> >>> removed unnecessary setter >>> >>> Project: http://git-wip-us.apache.org/repos/asf/wicket/repo >>> Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/69234c51 >>> Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/69234c51 >>> Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/69234c51 >>> >>> Branch: refs/heads/wicket-6.x >>> Commit: 69234c511e1c1f37ae4178a09f2b36151536c7ac >>> Parents: 30323a5 >>> Author: bitstorm <[email protected]> >>> Authored: Mon May 5 17:21:31 2014 +0200 >>> Committer: bitstorm <[email protected]> >>> Committed: Mon May 5 17:21:31 2014 +0200 >>> >>> ---------------------------------------------------------------------- >>> .../org/apache/wicket/request/mapper/mount/MountMapper.java | 5 >>> ----- >>> 1 file changed, 5 deletions(-) >>> ---------------------------------------------------------------------- >>> >>> >>> >>> http://git-wip-us.apache.org/repos/asf/wicket/blob/69234c51/wicket-request/src/main/java/org/apache/wicket/request/mapper/mount/MountMapper.java >>> ---------------------------------------------------------------------- >>> diff --git >>> a/wicket-request/src/main/java/org/apache/wicket/request/mapper/mount/MountMapper.java >>> b/wicket-request/src/main/java/org/apache/wicket/request/mapper/mount/MountMapper.java >>> index 61d89a6..ea6a0fd 100644 >>> --- >>> a/wicket-request/src/main/java/org/apache/wicket/request/mapper/mount/MountMapper.java >>> +++ >>> b/wicket-request/src/main/java/org/apache/wicket/request/mapper/mount/MountMapper.java >>> @@ -177,9 +177,4 @@ public class MountMapper extends AbstractMapper >>> return innerRequestMapper; >>> } >>> >>> - public void setInnerRequestMapper(IRequestMapper >>> innerRequestMapper) >>> - { >>> - this.innerRequestMapper = innerRequestMapper; >>> - } >>> - >>> } >>> >>> >> >
