Martin, Shouldn't WicketInternalException be named IWicketInternalException to be "compatible" with the "rest" of interfaces on the framework?
On Tue, Jun 24, 2014 at 4:16 PM, <[email protected]> wrote: > Repository: wicket > Updated Branches: > refs/heads/wicket-6.x fb77b39d6 -> c39c50966 > > > WICKET-5628 Introduce a marker interface for exception which are > recommended to be handler by the framework > > (cherry picked from commit baaab3c9b274245f4cb1608ea2904b986e5f975e) > > > Project: http://git-wip-us.apache.org/repos/asf/wicket/repo > Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/c39c5096 > Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/c39c5096 > Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/c39c5096 > > Branch: refs/heads/wicket-6.x > Commit: c39c50966b48a1d460ee7b6c4c746233b56a20e3 > Parents: fb77b39 > Author: Martin Tzvetanov Grigorov <[email protected]> > Authored: Tue Jun 24 17:15:29 2014 +0300 > Committer: Martin Tzvetanov Grigorov <[email protected]> > Committed: Tue Jun 24 17:16:02 2014 +0300 > > ---------------------------------------------------------------------- > .../apache/wicket/WicketInternalException.java | 25 ++++++++++++++++++++ > .../core/request/mapper/StalePageException.java | 3 ++- > .../http/servlet/ResponseIOException.java | 3 ++- > .../request/resource/PackageResource.java | 3 ++- > 4 files changed, 31 insertions(+), 3 deletions(-) > ---------------------------------------------------------------------- > > > > http://git-wip-us.apache.org/repos/asf/wicket/blob/c39c5096/wicket-core/src/main/java/org/apache/wicket/WicketInternalException.java > ---------------------------------------------------------------------- > diff --git > a/wicket-core/src/main/java/org/apache/wicket/WicketInternalException.java > b/wicket-core/src/main/java/org/apache/wicket/WicketInternalException.java > new file mode 100644 > index 0000000..df9f109 > --- /dev/null > +++ > b/wicket-core/src/main/java/org/apache/wicket/WicketInternalException.java > @@ -0,0 +1,25 @@ > +/* > + * Licensed to the Apache Software Foundation (ASF) under one or more > + * contributor license agreements. See the NOTICE file distributed with > + * this work for additional information regarding copyright ownership. > + * The ASF licenses this file to You under the Apache License, Version 2.0 > + * (the "License"); you may not use this file except in compliance with > + * the License. You may obtain a copy of the License at > + * > + * http://www.apache.org/licenses/LICENSE-2.0 > + * > + * Unless required by applicable law or agreed to in writing, software > + * distributed under the License is distributed on an "AS IS" BASIS, > + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or > implied. > + * See the License for the specific language governing permissions and > + * limitations under the License. > + */ > +package org.apache.wicket; > + > +/** > + * A marker interface for exceptions which are recommended to be handled > + * by the framework > + */ > +public interface WicketInternalException > +{ > +} > > > http://git-wip-us.apache.org/repos/asf/wicket/blob/c39c5096/wicket-core/src/main/java/org/apache/wicket/core/request/mapper/StalePageException.java > ---------------------------------------------------------------------- > diff --git > a/wicket-core/src/main/java/org/apache/wicket/core/request/mapper/StalePageException.java > b/wicket-core/src/main/java/org/apache/wicket/core/request/mapper/StalePageException.java > index b70b013..34ce8e8 100644 > --- > a/wicket-core/src/main/java/org/apache/wicket/core/request/mapper/StalePageException.java > +++ > b/wicket-core/src/main/java/org/apache/wicket/core/request/mapper/StalePageException.java > @@ -16,6 +16,7 @@ > */ > package org.apache.wicket.core.request.mapper; > > +import org.apache.wicket.WicketInternalException; > import org.apache.wicket.WicketRuntimeException; > import org.apache.wicket.request.component.IRequestablePage; > > @@ -25,7 +26,7 @@ import > org.apache.wicket.request.component.IRequestablePage; > * > * @author Matej Knopp > */ > -public class StalePageException extends WicketRuntimeException > +public class StalePageException extends WicketRuntimeException implements > WicketInternalException > { > private static final long serialVersionUID = 1L; > > > > http://git-wip-us.apache.org/repos/asf/wicket/blob/c39c5096/wicket-core/src/main/java/org/apache/wicket/protocol/http/servlet/ResponseIOException.java > ---------------------------------------------------------------------- > diff --git > a/wicket-core/src/main/java/org/apache/wicket/protocol/http/servlet/ResponseIOException.java > b/wicket-core/src/main/java/org/apache/wicket/protocol/http/servlet/ResponseIOException.java > index 44a5de5..2eaf3ee 100644 > --- > a/wicket-core/src/main/java/org/apache/wicket/protocol/http/servlet/ResponseIOException.java > +++ > b/wicket-core/src/main/java/org/apache/wicket/protocol/http/servlet/ResponseIOException.java > @@ -18,6 +18,7 @@ package org.apache.wicket.protocol.http.servlet; > > import java.io.IOException; > > +import org.apache.wicket.WicketInternalException; > import org.apache.wicket.WicketRuntimeException; > > /** > @@ -27,7 +28,7 @@ import org.apache.wicket.WicketRuntimeException; > * > * @author Pedro Santos > */ > -public class ResponseIOException extends WicketRuntimeException > +public class ResponseIOException extends WicketRuntimeException > implements WicketInternalException > { > /** */ > private static final long serialVersionUID = 1L; > > > http://git-wip-us.apache.org/repos/asf/wicket/blob/c39c5096/wicket-core/src/main/java/org/apache/wicket/request/resource/PackageResource.java > ---------------------------------------------------------------------- > diff --git > a/wicket-core/src/main/java/org/apache/wicket/request/resource/PackageResource.java > b/wicket-core/src/main/java/org/apache/wicket/request/resource/PackageResource.java > index 311774b..74cefd2 100644 > --- > a/wicket-core/src/main/java/org/apache/wicket/request/resource/PackageResource.java > +++ > b/wicket-core/src/main/java/org/apache/wicket/request/resource/PackageResource.java > @@ -26,6 +26,7 @@ import javax.servlet.http.HttpServletResponse; > > import org.apache.wicket.Application; > import org.apache.wicket.Session; > +import org.apache.wicket.WicketInternalException; > import org.apache.wicket.WicketRuntimeException; > import org.apache.wicket.core.util.lang.WicketObjects; > import > org.apache.wicket.core.util.resource.locator.IResourceStreamLocator; > @@ -78,7 +79,7 @@ public class PackageResource extends AbstractResource > implements IStaticCacheabl > /** > * Exception thrown when the creation of a package resource is not > allowed. > */ > - public static final class PackageResourceBlockedException extends > WicketRuntimeException > + public static final class PackageResourceBlockedException extends > WicketRuntimeException implements WicketInternalException > { > private static final long serialVersionUID = 1L; > > > -- Regards - Ernesto Reinaldo Barreiro
