Hi Peter, I'm glad to see you again here! Are you sure that Clirr has problems ? BuildBot has failed with the JS tests because we use hardcoded value of the port where NodeJS's connect server binds to. master branch acquired the port and wicket-6.x failed to bind it.
I think your change is OK but I'll test it right away here. Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Thu, Jul 17, 2014 at 1:45 PM, <p...@apache.org> wrote: > Repository: wicket > Updated Branches: > refs/heads/wicket-6.x 00cde3486 -> 49782ae6b > > > Revert "WICKET-5647 missing generic cast causes compile error on OS X / > jdk 8" since clirr plugin breaks with the change > > > Project: http://git-wip-us.apache.org/repos/asf/wicket/repo > Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/49782ae6 > Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/49782ae6 > Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/49782ae6 > > Branch: refs/heads/wicket-6.x > Commit: 49782ae6b04b19276d821364cda98eb8565d65fb > Parents: 00cde34 > Author: Peter Ertl <p...@apache.org> > Authored: Thu Jul 17 12:45:08 2014 +0200 > Committer: Peter Ertl <p...@apache.org> > Committed: Thu Jul 17 12:45:08 2014 +0200 > > ---------------------------------------------------------------------- > .../src/main/java/org/apache/wicket/util/value/ValueMap.java | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > ---------------------------------------------------------------------- > > > > http://git-wip-us.apache.org/repos/asf/wicket/blob/49782ae6/wicket-util/src/main/java/org/apache/wicket/util/value/ValueMap.java > ---------------------------------------------------------------------- > diff --git > a/wicket-util/src/main/java/org/apache/wicket/util/value/ValueMap.java > b/wicket-util/src/main/java/org/apache/wicket/util/value/ValueMap.java > index 2592c56..acba07f 100755 > --- a/wicket-util/src/main/java/org/apache/wicket/util/value/ValueMap.java > +++ b/wicket-util/src/main/java/org/apache/wicket/util/value/ValueMap.java > @@ -789,7 +789,7 @@ public class ValueMap extends LinkedHashMap<String, > Object> implements IValueMap > @Override > public <T extends Enum<T>> T getAsEnum(final String key, final > Class<T> eClass) > { > - return getEnumImpl(key, eClass, (T)null); > + return getEnumImpl(key, eClass, null); > } > > /** > >
