+1 to merge the branches
Notes: *) Is there anything to be released? This is how I see it: - the new Maven module should be skipped by maven-deploy-plugin, just like wicket-js-tests [1], because there is no point to deploy empty .jar files - BuildBot activates profile 'guide' to produce the .html(s) and .pdf files and copies them to BuildBot's /tmp/ folder, as it currently does for the Javadoc, and links to them at http://wicket.apache.org, just like the Javadocs [2] *) If I run 'mvn clean install -Pguide' at the parent module the build fails with: [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 01:31 min [INFO] Finished at: 2015-04-14T22:16:27+02:00 [INFO] Final Memory: 108M/3865M [INFO] ------------------------------------------------------------------------ [ERROR] Failed to execute goal org.grails:grails-maven-plugin:2.2.4:exec (pdf) on project wicket-user-guide: Unable to start Grails: java.lang.reflect.InvocationTargetException: PermGen space -> [Help 1] If I build only wicket-user-guide module with the same Maven command then everything is OK. This is not big issue because 'guide' profile is disabled by default so it won't break my local builds. We can tell BuildBot to use more memory. 1. https://github.com/apache/wicket/blob/8c83c5c50161b040fab0b748232a4fb5e7855e68/testing/wicket-js-tests/pom.xml#L44 2. http://ci.apache.org/projects/wicket/apidocs/6.x/, http://ci.apache.org/projects/wicket/apidocs/1.5.x/ and http://ci.apache.org/projects/wicket/apidocs/7.x/ Martin Grigorov Freelancer, available for hire! Wicket Training and Consulting https://twitter.com/mtgrigorov On Tue, Apr 14, 2015 at 6:38 PM, Tobias Soloschenko < tobiassolosche...@googlemail.com> wrote: > +1 > > kind regards > > Tobias > > > Am 14.04.2015 um 15:51 schrieb andrea del bene <an.delb...@gmail.com>: > > > > This is a vote to release the new module wicket-user-guide. > > > > This module is meant to integrate the user guide into the official GIT > repository. > > The module uses the Grails-Maven integration plugin in order to generate > the guide > > from Maven. > > This will make guide maintenance much easier and we can have different > version for different > > branches (6.x, 7.x, etc..). Last but not least, this will make much > easier to contribute > > to the guide, as we move from Subverion to Git. > > > > [ ] Yes, release it! > > [ ] No, don't release it! > > > > Feature branches branches: > > > > -grails-maven-integration (for master branch) > > -grails-maven-integration-6.x (for wicket-6.x branch) > > > > Andrea. > > >
