Hi Joachim, For 6.x I think it is enough to mark the methods/constructors as deprecated explaining why they don't work as expected anymore. For 7.x just remove the methods/constructors.
Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Wed, Apr 29, 2015 at 12:01 AM, Joachim Rohde < [email protected]> wrote: > Hi, > > by coincidence I realized that a few examples in the Wicketstuff project > GMap3 are broken (e.g. the marker examples). While I was starting to fix > those issues I realized that Google removed quite a lot of properties (like > shadows for markers (org.wicketstuff.gmap.api.GMarkerOptions#shadow), > #bouncy, etc.) Some of them can be replaced without any API breaks. > > But the GMarkerOptions class has for example this constructor: > > public GMarkerOptions(GMap gmap, GLatLng latLng, String title, GIcon icon, > GIcon shadow) > > As shadows are not supported by Google anymore this constructor makes no > sense at all. Google Maps ignores any programmatic specified shadows (at > the moment). > > My question is: how to handle this? > > Since version 7 (of Wicket(stuff)) is not out yet, API breaks on the > master branch are not problematic. But what should I do with the 6.x-branch? > > On one hand I would say API breaks are a no-go between minor versions. On > the other hand: the functionality is broken and cannot be replaced. > > I'm not quite sure how to handle this. Since Wicket updates are usually > drop-in replacements, an API break would be unpleasent. But in the current > state the documentation and the code suggests the developer some behaviour > which he will not get. > > Thoughts? > > Joachim >
