GitHub user gsmet opened a pull request:

    https://github.com/apache/wicket/pull/118

    WICKET-5906 Move StringResourceModel to a fluid API

    I was wondering if maybe setModel and setParameters should be more clear, 
such as setSubstitutionModel and setSubstitutionParameters.
    
    Comments welcome.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/openwide-java/wicket stringresourcemodel-fluid

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/wicket/pull/118.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #118
    
----
commit ebfe6e804c80abdc6748d6d45d3ae6e4128e86de
Author: Guillaume Smet <[email protected]>
Date:   2015-05-15T13:29:52Z

    WICKET-5906 Move StringResourceModel to a fluid API
    
    This commit breaks the API late in the release cycle of 7 but
    changes made to the constructors of StringResourceModel made
    some usages silently failing.
    
    We decided in favor of breaking the API to raise compilation
    errors so that users can fix their code.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to