It's integrated. I am going to delete the branch (WICKET-5819_Improvements)
Thanks a lot for the review Martin! :-)
kind regards
Tobias
Am 26.05.15 um 08:24 schrieb Martin Grigorov:
Sounds good!
Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov
On Tue, May 26, 2015 at 12:32 AM, Tobias Soloschenko <
[email protected]> wrote:
Hi again,
The only thing which is left to be done is to close the inputstream after
the PartWriterCallback has finished writing. (Because it is not done via
ResourceStream)
What do you think?
After that change and some tests / review the branch can be merged I think.
kind regards
Tobias
Am 25.05.2015 um 22:05 schrieb Martin Grigorov <[email protected]>:
Hi Tobias,
"readPartially" sounds to me like related to "Partial content, code 206",
i.e. related to the functionality about ranges.
Maybe "readBuffered"?
The change at
https://git1-us-west.apache.org/repos/asf/wicket/repo?p=wicket.git;a=commitdiff;h=7e3fed6dce27d1cc5c68c7901eecec08091d59c4;hp=b3c9843f805560f6685106b97cd2f9ddab8c28a9
is not very clear to me. Why it is needed exactly?
How the buffering leads to the need to not closing the resource stream?
I've made some comments in GitHub about small things in the javadoc
improvements. Did you receive notifications?
Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov
On Sun, May 24, 2015 at 2:48 PM, Tobias Soloschenko <
[email protected]> wrote:
Hello everyone,
I just want to introduce a new fluent method to PackageResource /
PackageResourceReference which is called readPartially(boolean). It
adresses a memory consumption issue while reading media files (audio,
video) or other large resource files.
Before this implementation the content of each file shipped with a
PackageResourceReference were copied into memory and then the part the
client requested (Content-Range, Range, Accept-Range) was transfered to
the
client.
Now only the part the client requested is read and transfered directly
to
the response, without storing it into memory (ByteArrayInputStream,
byte[])
- For normal the PackageResourceReference is reading it from disk.
If the method isn't invoked or invoked with false the old behavior is
used.
The only limitation is that no
org.apache.wicket.resource.ITextResourceCompressor will be used if the
flag
is set to true, because the content will not be analyzed.
I decided to first put it into a branch and discuss it here:
Branch:
https://github.com/apache/wicket/compare/WICKET-5819_Improvements
Ticket: https://issues.apache.org/jira/browse/WICKET-5819
What do you think?
kind regards
Tobias
