fine too! Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov
On Mon, Sep 21, 2015 at 1:51 PM, Martijn Dashorst < [email protected]> wrote: > or WICKET8? makes grepping easy for these kinds of things. > > Martijn > > On Mon, Sep 21, 2015 at 1:45 PM, Martin Grigorov <[email protected]> > wrote: > > On Mon, Sep 21, 2015 at 1:42 PM, <[email protected]> wrote: > > > >> Deprecated MarkupContainer#get(int), swap(int,int) > >> > >> Both methods are deemed unnecessary and are slated for deletion in > wicket > >> 8. > >> > >> > >> Project: http://git-wip-us.apache.org/repos/asf/wicket/repo > >> Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/3677e6b9 > >> Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/3677e6b9 > >> Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/3677e6b9 > >> > >> Branch: refs/heads/WICKET-5981 > >> Commit: 3677e6b96e1c04eb8162ec40fe789a0fff8d532b > >> Parents: 5271f27 > >> Author: Martijn Dashorst <[email protected]> > >> Authored: Mon Sep 21 13:41:51 2015 +0200 > >> Committer: Martijn Dashorst <[email protected]> > >> Committed: Mon Sep 21 13:41:51 2015 +0200 > >> > >> ---------------------------------------------------------------------- > >> .../main/java/org/apache/wicket/MarkupContainer.java | 12 > ++++++++---- > >> 1 file changed, 8 insertions(+), 4 deletions(-) > >> ---------------------------------------------------------------------- > >> > >> > >> > >> > http://git-wip-us.apache.org/repos/asf/wicket/blob/3677e6b9/wicket-core/src/main/java/org/apache/wicket/MarkupContainer.java > >> ---------------------------------------------------------------------- > >> diff --git > >> a/wicket-core/src/main/java/org/apache/wicket/MarkupContainer.java > >> b/wicket-core/src/main/java/org/apache/wicket/MarkupContainer.java > >> index 5f0d035..c87bd00 100644 > >> --- a/wicket-core/src/main/java/org/apache/wicket/MarkupContainer.java > >> +++ b/wicket-core/src/main/java/org/apache/wicket/MarkupContainer.java > >> @@ -1011,7 +1011,9 @@ public abstract class MarkupContainer extends > >> Component implements Iterable<Comp > >> * @throws ArrayIndexOutOfBoundsException > >> * when {@code index} exceeds {@code size()} > >> * @return child component at the specified index > >> + * @deprecated this method is marked for deletion for WICKET-8 > >> > > > > WICKET-8 is a bit confusing because it looks like a JIRA ticket > > > > Before we have used Wicket.next and Wicket 7.0, so I suggest to use > "Wicket > > 8.0.0" instead > > > > > >> */ > >> + @Deprecated > >> public final Component get(int index) > >> { > >> Component childAtIndex = null; > >> @@ -1626,20 +1628,22 @@ public abstract class MarkupContainer extends > >> Component implements Iterable<Comp > >> * index of first component to be swapped > >> * @param idx2 > >> * index of second component to be swapped > >> + * @deprecated this method is marked for deletion for WICKET-8 > >> */ > >> + @Deprecated > >> public final void swap(int idx1, int idx2) > >> { > >> int size = children_size(); > >> if (idx1 < 0 || idx1 >= size) > >> { > >> - throw new IndexOutOfBoundsException("Argument > idx > >> is out of bounds: " + idx1 + "<>[0," + > >> - size + ")"); > >> + throw new IndexOutOfBoundsException( > >> + "Argument idx is out of bounds: " + > idx1 + > >> "<>[0," + size + ")"); > >> } > >> > >> if (idx2 < 0 || idx2 >= size) > >> { > >> - throw new IndexOutOfBoundsException("Argument > idx > >> is out of bounds: " + idx2 + "<>[0," + > >> - size + ")"); > >> + throw new IndexOutOfBoundsException( > >> + "Argument idx is out of bounds: " + > idx2 + > >> "<>[0," + size + ")"); > >> } > >> > >> if (idx1 == idx2) > >> > >> > > > > -- > Become a Wicket expert, learn from the best: http://wicketinaction.com >
