Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/140#discussion_r42318419
--- Diff:
wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
---
@@ -1253,6 +1253,48 @@
}
};
+ Wicket.Ajax.ChanneledAjax = Wicket.Class.create();
+
+ Wicket.Ajax.ChanneledAjax.prototype = {
+
+ initialize: function(channelName, channelType, channelManager,
ajaxTransport) {
+ this.name = channelName;
+ this.type = channelType;
+ this.channel = this.name + "|" + this.type;
+ this.channelManager = channelManager;
+ this.transport = ajaxTransport? ajaxTransport :
jQuery.ajax;
+ },
+
+ ajax: function(url, options) {
+ if (typeof url === "object") {
+ options = url;
+ url = undefined;
--- End diff --
This looks wrong. IMO if `url` is Object then:
* if `options` is Object too then merge them
* if `options` is undefined then: `options = url; url = options.u ||
options.url`
There is no unit test for `url` being Object.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
