Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/143#discussion_r46208210
--- Diff:
wicket-core/src/main/java/org/apache/wicket/markup/html/image/ExternalImage.java
---
@@ -0,0 +1,274 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.wicket.markup.html.image;
+
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.List;
+
+import org.apache.wicket.markup.ComponentTag;
+import org.apache.wicket.markup.html.WebComponent;
+import org.apache.wicket.markup.html.image.Image.Cors;
+import org.apache.wicket.model.IModel;
+import org.apache.wicket.model.Model;
+
+/**
+ * A component to display external images. The src / srcset information
are hold in models
+ *
+ * @author Tobias Soloschenko
+ *
+ */
+public class ExternalImage extends WebComponent
+{
+
+ private static final long serialVersionUID = 1L;
+
+ /** The x values to be used within the srcset */
+ private List<String> xValues = null;
+
+ /** The sizes of the responsive images */
+ private List<String> sizes = null;
+
+ /**
+ * Cross origin settings
+ */
+ private Cors crossOrigin = null;
+
+ private IModel<?>[] srcSet;
+
+ /**
+ * Creates an external image
+ *
+ * @param id
+ * the component id
+ * @param src
+ * the source URL
+ * @param srcSet
+ * a list of URLs placed in the srcset attribute
+ */
+ public ExternalImage(String id, String src, String... srcSet)
+ {
+ this(id, src != null ? Model.of(src) : null,
convertToModel(srcSet));
+ }
+
+ /**
+ * Creates an external image
+ *
+ * @param id
+ * the component id
+ * @param src
+ * the model source URL
+ * @param srcSetModels
+ * a model list of URLs placed in the srcset attribute
+ */
+ public ExternalImage(String id, IModel<?> src, IModel<?>...
srcSetModels)
--- End diff --
Why `IModel<?>` and not `IModel<String>`?
Same for srcSet.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
