Github user svenmeier commented on a diff in the pull request: https://github.com/apache/wicket/pull/151#discussion_r48385193 --- Diff: wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/AjaxLazyLoadPanel.java --- @@ -187,8 +237,56 @@ public Component getLoadingComponent(final String markupId) { IRequestHandler handler = new ResourceReferenceRequestHandler( AbstractDefaultAjaxBehavior.INDICATOR); - return new Label(markupId, "<img alt=\"Loading...\" src=\"" + - RequestCycle.get().urlFor(handler) + "\"/>").setEscapeModelStrings(false); + return new Label(markupId, + "<img alt=\"Loading...\" src=\"" + RequestCycle.get().urlFor(handler) + "\"/>") + .setEscapeModelStrings(false); } + /** + * Factory method for creating the lazily loaded component that replaces the spinner after + * {@link #isReadyForReplacement()} returns {@code true}. You may call setRenderBodyOnly(true) + * on this component if you need the body only. + * + * @param markupId + * The components markupid. + * @return The component that must be lazy created. + */ + public abstract Component getLazyLoadComponent(String markupId); + + /** + * The AJAX timer for updating the AjaxLazyLoadPanel. Is designed to be a page-local singleton + * keeping track of multiple LazyLoadPanels using reference counting. + */ + private class AjaxLazyLoadTimer extends AbstractAjaxTimerBehavior --- End diff -- This should probably be static to prevent a dangling reference to the surrounding component.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---