Hi Martin,
I will do so tomorrow morning. :-)
kind regards
Tobias
Am 26.12.15 um 13:19 schrieb Martin Grigorov:
Hi Tobias,
Please create a ticket in JIRA and commit your fix.
Thank you!
Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov
On Wed, Dec 23, 2015 at 9:17 AM, Tobias Soloschenko <
[email protected]> wrote:
Great! Thanks!
kind regards
Tobias
Am 23.12.2015 um 09:10 schrieb Martin Grigorov <[email protected]>:
Hi Tobias,
I suggest to deploy a -SNAPSHOT version with your changes at OpenShift
and
see whether it actually fixes the problem and then merge the PRs.
Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov
On Wed, Dec 23, 2015 at 9:07 AM, Maxim Solodovnik <[email protected]>
wrote:
yes, I believe everything should work as expected now :)
On Wed, Dec 23, 2015 at 2:05 PM, Tobias Soloschenko <
[email protected]> wrote:
I think it is fixed with those two pull requests, because for an
example
of
the byte range 0-7:
0 = first byte
...
7 = last byte
which leads to a total byte count of 8 - right? :-)
kind regards
Tobias
2015-12-23 8:51 GMT+01:00 Maxim Solodovnik <[email protected]>:
During my tests I have compared packets being sent by Apache HTTPD
server
and packets being sent by my application
On Wed, Dec 23, 2015 at 1:50 PM, Tobias Soloschenko <
[email protected]> wrote:
Yep, I also tested it on Mac OSX Safari and iOS Safari, but it was
locally
running for me. Strange.
2015-12-23 8:44 GMT+01:00 Maxim Solodovnik <[email protected]>:
I have tested it on Mac OS X Safai and iOS Safari, both was working
this
way
Safari is very strict in such things :(
On Wed, Dec 23, 2015 at 1:41 PM, Tobias Soloschenko <
[email protected]> wrote:
Yep I see you also add +1 to read the stream. I did it this way
which I
think is wrong, because the last byte is inclusive:
https://github.com/apache/wicket/blob/master/wicket-core/src/main/java/org/apache/wicket/request/resource/PartWriterCallback.java#L144
boundedInputStream = new BoundedInputStream(inputStream, endbyte
-
startbyte);
It should be this: boundedInputStream = new
BoundedInputStream(inputStream,
(endbyte - startbyte)+1); to read the stream.
kind regards
Tobias
2015-12-23 8:35 GMT+01:00 Maxim Solodovnik <[email protected]
:
In my old code the following formula was used:
https://github.com/apache/openmeetings/blob/3.0.x/src/web/java/org/apache/openmeetings/web/util/RecordingResourceReference.java#L80
On Wed, Dec 23, 2015 at 1:30 PM, Tobias Soloschenko <
[email protected]> wrote:
This is only a guess, but I think the BoundedInputStream used
in org.apache.wicket.request.resource.PartWriterCallback is
calculating
the
size exclusively. If I write:
boundedInputStream = new BoundedInputStream(inputStream,
(endbyte -
startbyte)+1);
100 bytes are returned.
WDYT?
kind regards
Tobias
2015-12-23 8:23 GMT+01:00 Maxim Solodovnik <
[email protected]
:
Actually the only issue I had with video playing was caused
by
incorrect
calculation of *Ranges* :(
On Wed, Dec 23, 2015 at 1:22 PM, Tobias Soloschenko <
[email protected]> wrote:
Yep, on Chrome everything is playing well.
Yesterday I found out that:
curl --range 0-99
http://examples7x.wicket.apache.org/videos/wicket/resource/org.apache.wicket.examples.media.Home/video1-ver-538557E5F248D450160FC81033930591.mp4
-o /dev/null
returns 99 bytes and not 100 as expected in this
document:
https://developer.apple.com/library/safari/documentation/AppleApplications/Reference/SafariWebContent/CreatingVideoforSafarioniPhone/CreatingVideoforSafarioniPhone.html#//apple_ref/doc/uid/TP40006514-SW6
But this:
curl --range 0-99
http://media.w3.org/2010/05/video/movie_300.mp4
-o
/dev/null
returns 100 bytes.
Maybe this is causing the issue. However locally it is
playing
without
any
issues. That is what I am wondering of.
kind regards
Tobias
2015-12-23 8:15 GMT+01:00 Maxim Solodovnik <
[email protected]
:
Is it Safari only issue? Is everything OK with Chrome?
On Wed, Dec 23, 2015 at 1:12 PM, Tobias Soloschenko <
[email protected]> wrote:
Hi all,
I tried out the video examples with Safari:
http://examples7x.wicket.apache.org/videos/ - The
videos
are
only
playing
sound.
However if I play them on localhost (running the
examples
locally):
http://127.0.0.1:8080/videos/ - they are working.
I don't know yet whats wrong, but I try to figure out
these
days.
kind regards
Tobias
--
WBR
Maxim aka solomax
--
WBR
Maxim aka solomax
--
WBR
Maxim aka solomax
--
WBR
Maxim aka solomax
--
WBR
Maxim aka solomax
--
WBR
Maxim aka solomax
