Great! I also saw you are keeping the existing inner text in case of null model, that's perfect to me :) Thank you very much, Martin!
On Aug 15, 2016 15:35, "Martin Grigorov" <[email protected]> wrote: > https://issues.apache.org/jira/browse/WICKET-6225 > Done! > > Martin Grigorov > Wicket Training and Consulting > https://twitter.com/mtgrigorov > > On Mon, Jul 25, 2016 at 10:54 AM, Sebastien <[email protected]> wrote: > > > +1 to fix :) > > > > On Jul 25, 2016 10:40, "Martin Grigorov" <[email protected]> wrote: > > > > > Thanks, Sebastien! > > > > > > Indeed <input type="button" value="Three"/> works! > > > We need to fix this! > > > > > > Martin Grigorov > > > Wicket Training and Consulting > > > https://twitter.com/mtgrigorov > > > > > > On Mon, Jul 25, 2016 at 10:36 AM, Sebastien <[email protected]> wrote: > > > > > > > Button value attribute never existed afaik. You point a very good > > > subject, > > > > because the model should stands for the inner text but it never has > > been > > > > the case (unlike input type button where the model is the value > > attr)... > > > > That's an update i wanted to do since years ! :/ > > > > > > > > On Jul 25, 2016 10:12, "Martin Grigorov" <[email protected]> > wrote: > > > > > > > > > Hi, > > > > > > > > > > Button.java javadoc says that the model is used as a label for the > > > button > > > > > by using it as "value" attribute [1] [2]. > > > > > And I always thought that <button value="..."> is indeed used as a > > > label. > > > > > But I just tried: > > > > > > > > > > <button>One</button> > > > > > <button value="Two"></button> > > > > > > > > > > in a plain .html and the second one doesn't have its label. > > > > > > > > > > Have HTML changed at some point or me and the original author of > > > > > Button.java have read the wrong book ? > > > > > > > > > > > > > > > 1. > > > > > > > > > > > > > > > > > https://github.com/apache/wicket/blob/e79fcb8787187108e8a16b2ae9abab > > ecfcc76cf2/wicket-core/src/main/java/org/apache/wicket/ > > markup/html/form/Button.java#L81 > > > > > 2. > > > > > > > > > > > > > > > > > https://github.com/apache/wicket/blob/e79fcb8787187108e8a16b2ae9abab > > ecfcc76cf2/wicket-core/src/main/java/org/apache/wicket/ > > markup/html/form/Button.java#L199-L202 > > > > > > > > > > Martin Grigorov > > > > > Wicket Training and Consulting > > > > > https://twitter.com/mtgrigorov > > > > > > > > > > > > > > >
