Github user pedrosans commented on a diff in the pull request:
https://github.com/apache/wicket/pull/210#discussion_r99944413
--- Diff:
wicket-core/src/test/java/org/apache/wicket/core/request/mapper/MountedMapperTest.java
---
@@ -714,7 +714,7 @@ public boolean isNewPageInstance()
@Test
public void placeholderEncode4()
{
- PageProvider provider = new PageProvider(new MockPage())
+ PageProvider provider = new PageProvider(MockPage.class)
--- End diff --
Not the same and the change is needed. This test follows up by changing the
page provider which will have no impact on the provider that already holds an
instance.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
