Github user svenmeier commented on a diff in the pull request:
https://github.com/apache/wicket/pull/214#discussion_r107100653
--- Diff:
wicket-core/src/main/java/org/apache/wicket/page/PageAccessSynchronizer.java ---
@@ -93,8 +94,8 @@ public Duration getTimeout(int pageId)
*/
public void lockPage(int pageId) throws CouldNotLockPageException
{
- final Thread thread = Thread.currentThread();
- final PageLock lock = new PageLock(pageId, thread);
+ final RequestCycle cycle = RequestCycle.get();
--- End diff --
Not true!
As long as one RequestCycle holds the lock on a page, no other RequestCycle
can get a lock. It doesn't make any difference whether we lock on the thread or
the RequestCycle.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
