Github user klopfdreh commented on a diff in the pull request:

    https://github.com/apache/wicket/pull/227#discussion_r130974278
  
    --- Diff: 
wicket-experimental/wicket-http2/wicket-http2-core/src/main/java/org/apache/wicket/http2/markup/head/PushHeaderItem.java
 ---
    @@ -361,7 +366,32 @@ else if (url.toString().startsWith("."))
                                        url = url.toString().substring(1);
                                }
     
    -                           urls.add(url.toString());
    +                           // The context path and the filter have to be 
applied to the URL, because otherwise
    --- End diff --
    
    Is someone able to review this and the following lines of code? I dislike 
the handling about the slashes in the url and to build up the path part that 
way.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to