On Thu, Jan 4, 2018 at 5:17 PM, Andrea Del Bene <an.delb...@gmail.com> wrote:
> I couldn't sleep because I've read about Meltdown and Spectre bugs :-). > All joking aside, I've added a test case for FeedbackPanel and session > messages. To restore the original behavior I've changed > FeedbackMessagesModel adding an includeSession flag which is true by > default. > > WDYT? > LGTM! Thank you! > > On 04/01/2018 01:40, Martijn Dashorst wrote: > >> GO TO SLEEP YOU FOOL! >> >> (I couldn’t sleep due to a storm rattling my solar panels on our roof so >> I have an excuse. What’s yours?) >> >> Martijn >> >> Ps HAPPY NEW YEAR! >> >> Op 4 jan. 2018 om 01:23 heeft Andrea Del Bene <an.delb...@gmail.com> het >>> volgende geschreven: >>> >>> I can take care of it tomorrow. >>> >>> >>> >>> On 03/01/2018 23:22, Martijn Dashorst wrote: >>>> >>>>> On Wed, Jan 3, 2018 at 10:43 PM, Andrea Del Bene <an.delb...@gmail.com> >>>>> wrote: >>>>> Hi, >>>>> >>>>> as a result of WICKET-6514 now FeedbackPanel doesn't show anymore >>>>> session >>>>> messages. I'm not sure if this was intentional, but I think >>>>> FeedbackPanel >>>>> shouldn't change its behavior. Should we modify FeedbackPanel to >>>>> restore the >>>>> original behavior? >>>>> >>>> Yes. There are countless applications depending on this type of >>>> messaging. This is a regression. >>>> >>>> Martijn >>>> >>> >
