Thank you Sven. I confirm my positive vote. On Fri, Feb 16, 2018 at 2:25 PM, Sven Meier <s...@meiers.net> wrote:
> Hi all, > > there's no need to make a fuss about this feature. > > When Korbinian and I started working on deferred JavaScript, I was under > the impression: > > a) that the JavaScript part is sorted out already > b) every framework supports it (to be kind of cool) > b) we have to rework major parts to bake this into Wicket > > Now I understand that > > x) deferred loading of JavaSript is fucked up in browsers > y) other frameworks are struggling with this too > z) only a tiny change was required in Wicket to allow people to experiment > with deferred JavaScript > > We *need* a note in the release notes for z), as the handling of > IHeaderResponseDecorator has slightly. I don't consider this a big deal, > because users will have to change a *single* place only *if* they use > JavaScriptFilteredIntoFooterHeaderResponse at all. > Compare that with introducing Optional for the return of > RequestTarget#find(): that might *silently* break applications and requires > to rework possibly *hundreds* of code places. > > Furthermore WICKET- 6498 added a single class > JavaScriptDeferHeaderResponse only - yes, it's experimental but with no API > surface to break in the future. Nobody has to use it so I don't see the > need to praise/warn about it in the release notes. > I don't consider it broken, browsers are broken. However I have no problem > to remove that class: we can just put it into confluence or wicketstuff. > > Once again: It is a *single* class with *no* API - that's nothing compared > to component queueing :P > > Have fun > Sven > > > > > Am 16.02.2018 um 13:32 schrieb Andrea Del Bene: > >> On Feb 16, 2018 10:50 AM, "Martin Grigorov" <mgrigo...@apache.org> wrote: >> >> On Fri, Feb 16, 2018 at 10:41 AM, Andrea Del Bene <an.delb...@gmail.com> >> wrote: >> >> That's what I'd write in the release note: >>> >>> Caveats >>> ------------------ >>> WICKET-6498 might not work as expected due to a known issues with all >>> >> major >> >>> browsers (Chrome, Firefox, IE > 10) which allows deferred scripts to be >>> executed before DOMContentLoaded is fired. For this reason WICKET-6498 >>> should be avoided for production applications and used carefully. >>> >>> WDYT? >>> >>> Why do we ship it if it is known to be broken ? >> AFAIR we don't have such precedent before. >> >> >> Have you forgotten about components queueing :-D :-D? >> >> >> >> On Thu, Feb 15, 2018 at 9:15 PM, Korbinian Bachl < >>> korbinian.ba...@whiskyworld.de> wrote: >>> >>> in short: since IE 11 and chrome as well as FF the browsers dont fire >>>> >>> the >> >>> DOMContentLoaded of scripts the way one would expect. This happens as >>>> >>> the >> >>> browsers branch multiple threads that each thread put together execution >>>> groups of orders leading to inline-JS getting executed and events on >>>> >>> these >>> >>>> fired without the knowledge of other JS resources as long as these are >>>> defered and / or / asnyc'd >>>> >>>> Even worse, an app that may work well in local mode may break in >>>> production as network timing as well as client CPU count (influences >>>> thread) and speed of CPU and or GPU (yep... ) may change the timings the >>>> event DOMContentLoaded gets fired; >>>> >>>> even JQuery guys are plagued by this and have no real solution to it now >>>> IMHO https://github.com/jquery/jquery/issues/3271 >>>> >>>> I think we can get a real working one for wicket but had no time yet to >>>> try it out; Idea is to create the wicket object in the head at first >>>> >>> inline >>> >>>> script before any JS resources (defered or not) so that the page itself >>>> cant break because of this >>>> >>>> >>>> ----- Ursprüngliche Mail ----- >>>> >>>>> Von: "Andrea Del Bene" <an.delb...@gmail.com> >>>>> An: dev@wicket.apache.org >>>>> Gesendet: Donnerstag, 15. Februar 2018 16:48:18 >>>>> Betreff: Re: [VOTE] Release Apache Wicket 8.0.0-M9 >>>>> Hi, >>>>> >>>>> I need your help. what's exactly the caveat about WICKET-6498? It >>>>> >>>> uses >> >>> javascript events that might not be supported buy browser? >>>>> >>>>> On Sun, Feb 11, 2018 at 6:16 PM, Korbinian Bachl < >>>>> korbinian.ba...@whiskyworld.de> wrote: >>>>> >>>>> +1 to release for M9 >>>>>> >>>>>> IMHO a warning should be added with regards to WICKET-6498 as it is >>>>>> >>>>> not >>> >>>> yet working in a reliable way but may break depending on client >>>>>> >>>>> specifics; >>>> >>>>> ----- Ursprüngliche Mail ----- >>>>>> >>>>>>> Von: "Andrea Del Bene" <an.delb...@gmail.com> >>>>>>> An: dev@wicket.apache.org >>>>>>> Gesendet: Sonntag, 11. Februar 2018 17:34:08 >>>>>>> Betreff: [VOTE] Release Apache Wicket 8.0.0-M9 >>>>>>> This is a vote to release Apache Wicket 8.0.0-M9 >>>>>>> >>>>>>> Please download the source distributions found in our staging area >>>>>>> linked below. >>>>>>> >>>>>>> I have included the signatures for both the source archives. This >>>>>>> >>>>>> vote >>> >>>> lasts for 72 hours minimum. >>>>>>> >>>>>>> [ ] Yes, release Apache Wicket 8.0.0-M9 >>>>>>> [ ] No, don't release Apache Wicket 8.0.0-M9, because ... >>>>>>> >>>>>>> Distributions, changelog, keys and signatures can be found at: >>>>>>> >>>>>>> https://dist.apache.org/repos/dist/dev/wicket/8.0.0-M9 >>>>>>> >>>>>>> Staging repository: >>>>>>> >>>>>>> https://repository.apache.org/content/repositories/ >>>>>>> >>>>>> orgapachewicket-1105/ >>>> >>>>> The binaries are available in the above link, as are a staging >>>>>>> repository for Maven. Typically the vote is on the source, but >>>>>>> >>>>>> should >>> >>>> you find a problem with one of the binaries, please let me know, I >>>>>>> >>>>>> can >>> >>>> re-roll them some way or the other. >>>>>>> >>>>>>> Staging git repository data: >>>>>>> >>>>>>> Repository: g...@github.com:bitstorm/wicket.git >>>>>>> Branch: build/wicket-8.0.0-M9 >>>>>>> Release tag: rel/wicket-8.0.0-M9 >>>>>>> >>>>>>> >>>>>>> ============================================================ >>>>>>> >>>>>> ============ >>>> >>>>> The signatures for the source release artefacts: >>>>>>> >>>>>>> >>>>>>> Signature for apache-wicket-8.0.0-M9.zip: >>>>>>> >>>>>>> -----BEGIN PGP SIGNATURE----- >>>>>>> Version: GnuPG v1 >>>>>>> >>>>>>> iQIcBAABAgAGBQJagFiiAAoJEIePAfqo01bhPxsP/jgrMjf/3IVHWSOftoHEYf+j >>>>>>> Wtb8gvB0Y3sY8L6syj5GQCuhceaovbq3NCnAz0qrn/tLRuUnybyj8GfyMrQv4wNP >>>>>>> rDj7zPRqhsldgbSTsjDP98b0V99F5ct68HsxOr3LzxNijFNFRxIDnF+73QZNjUcA >>>>>>> YL4xuxP80WvMb1mmwASg+l9MxhEWpeYWoyOBHNWFmjgI/4r3ineq2YSjAq3MZKOC >>>>>>> Vu4CqYS+ajEFMqduHU4aa9j4Lj4X81by34c9xCKERaioI7kFhoZzhws6ufoA/wNo >>>>>>> EPBPBft9oG72rUfX9VwyZxHMBmU50eKmEtFeCtWXqu5v8Js2rVTxmw4EGKENj3+8 >>>>>>> Kiup7+zXu9t07mvoS4mCJ8fcl7P+g24e02pdqHDBea/a7zAKUdrIe6MCMJ2Qlw0g >>>>>>> E/xlDJ4utPcU7E88IQiCLpmarN3uBZKnivzm3Uir5U0dJtffu4IacABg5Svp3DAl >>>>>>> TcUOmM9QxKYjD8Ey6uORoGTm3gZmx4FcnNjSw0ch27fyNUpYVfEyU88KH9vz2dQP >>>>>>> Tcs9LxRpII4pBGXu0nK5zWZfXBgqxYfUUrIroCrzVWub+wqEw8pXo2K9GdrUYpcg >>>>>>> K12TIpW3X43zNG7L6lTJtFe2yffVLdyS1DDoqU3QI4gHe/vdIC3atd4BP0Aeauj1 >>>>>>> jIvOQJKU+bwlubLLneTg >>>>>>> =MOtP >>>>>>> -----END PGP SIGNATURE----- >>>>>>> >>>>>>> Signature for apache-wicket-8.0.0-M9.tar.gz: >>>>>>> >>>>>>> -----BEGIN PGP SIGNATURE----- >>>>>>> Version: GnuPG v1 >>>>>>> >>>>>>> iQIcBAABAgAGBQJagFihAAoJEIePAfqo01bheU8QAIkUJK3zjjVeARkAbN3Zi1hE >>>>>>> b5qnaSiXkuxZyTfVzDS4Ui7OZwIOY1RJ1YlJ4fZwio+BJhpxnCiPjPLRC1VNwA4q >>>>>>> oMBsOfwePU92kJYQERfVfJgNkk1ixyh52k3qsoS4EIdKT+bOW52hT8zaXRNazhG3 >>>>>>> nwyDTe00c/ibj5KM68L7R4LXef6tbnZAjegKBDNUsvWQltwE2xc1lVapnNoqtOAM >>>>>>> B26gWh5G8QDQxjWJESk9ik+Vyyg9We8lABV5+Hkqrugv3yECiD9ObcYE29bE/OHN >>>>>>> hfgzo5EX+umXzTkoHltQ0ZxAxPiWWquH3tjsy1/z/8r3BT4YBZs+PIoOCSPem6kK >>>>>>> aUoJiBEZ55WsBVd5NdYY7PiSwZ2KWsuE1XmqADY+USuhytPln04YNK9srdVESnCL >>>>>>> sBxGP0kgHKrD92O1aTLpzan3VhD1O8KzjH/8MMEWJxevQbW/gorlAjh7+iCVcH7g >>>>>>> YurqMjtq91YFFlZwU5YlczfhnZmR4/Efp3/O57S76HOyaMWYloj0vs2OQH3TJTm7 >>>>>>> GLvO/b9R46mgnnlHVhxN2z1f0xTOFwpeXIjchb+jHs0SuxOVAqrIpGmsFG8Siv/V >>>>>>> 3spQEzAzM/Enl2PgaCNlU0aus/i35FRLEmlCf7nyuwVQCbsE3d5W/fKLYeJOD9Wq >>>>>>> CCJOHO3iofZ0wlGnB5J7 >>>>>>> =/qPh >>>>>>> -----END PGP SIGNATURE----- >>>>>>> >>>>>>> ============================================================ >>>>>>> >>>>>> ============ >>>> >>>>> CHANGELOG for 8.0.0-M9: >>>>>>> >>>>>>> ** Bug >>>>>>> >>>>>>> * [WICKET-6332] - NullPointerException in >>>>>>> >>>>>> PageParameters#equals() >>> >>>> * [WICKET-6441] - MockHttpSession and MockSessionStore don't >>>>>>> >>>>>> call >>> >>>> onInvalidate() on invalidate() >>>>>>> * [WICKET-6448] - Provide behavior that disables a button after >>>>>>> >>>>>> click >>>> >>>>> * [WICKET-6477] - Component.getDefaultModelObject() wraps in >>>>>>> RuntimeException instead of WicketRuntimeException >>>>>>> * [WICKET-6484] - Wicket.Cookie.set does not set 'secure' flag >>>>>>> * [WICKET-6489] - Exception when "identifier|code" javascript >>>>>>> >>>>>> is >> >>> not start on PrependJavaScript >>>>>>> * [WICKET-6491] - AjaxDownload is not working in blob mode for >>>>>>> Microsoft browsers >>>>>>> * [WICKET-6492] - javascript files are not minified in >>>>>>> >>>>>> deployment >>> >>>> mode and not united >>>>>>> * [WICKET-6493] - WebSocket SessionIds are wrong (HttpSession >>>>>>> >>>>>> one >>> >>>> used instead of Websocket one) + NPE if no HttpSession is found >>>>>>> >>>>>> during >>> >>>> Handshake Request >>>>>>> * [WICKET-6496] - Duplicate definition of interface JSONString >>>>>>> * [WICKET-6501] - DefaultPageManagerProvider does not honour >>>>>>> StoreSettings.setAsynchronous(false) >>>>>>> * [WICKET-6506] - Performance issue when large component isn't >>>>>>> >>>>>> visible >>>>>> >>>>>>> * [WICKET-6512] - pageId is being reset during >>>>>>> Session::replaceSession() call >>>>>>> * [WICKET-6513] - NullPointerException at >>>>>>> PageStoreManager$SessionEntry after login >>>>>>> * [WICKET-6518] - Memory leaks on quickstart restart in tomcat >>>>>>> * [WICKET-6522] - ThreadLocal leak in PageStoreManager >>>>>>> * [WICKET-6523] - Two AbstractAjaxTimerBehaviors on same >>>>>>> >>>>>> component >>> >>>> timeId conflict >>>>>>> * [WICKET-6524] - Do not require bean validation 2.0.0 >>>>>>> * [WICKET-6529] - Feedback from onSubmit not rendered on >>>>>>> >>>>>> stateless >>> >>>> pages >>>>>>> * [WICKET-6530] - Race-condition in session invalidation >>>>>>> >>>>>>> ** New Feature >>>>>>> >>>>>>> * [WICKET-6497] - unify javascript files >>>>>>> * [WICKET-6498] - wicket 8 - js to asnyc and or defer >>>>>>> >>>>>>> ** Improvement >>>>>>> >>>>>>> * [WICKET-6055] - AjaxLazyLoadPanel should provide non-blocking >>>>>>> lazy load >>>>>>> * [WICKET-6284] - Introduce lambda-enhanced factory method in >>>>>>> ResourceReference >>>>>>> * [WICKET-6499] - Support for Bean Validation 2.0 >>>>>>> * [WICKET-6503] - Ajax refresh and feedback panel >>>>>>> * [WICKET-6504] - Use a serializable model for >>>>>>> >>>>>> FileSystemResource's >>>> >>>>> path >>>>>>> * [WICKET-6509] - Import junit packages as optional >>>>>>> * [WICKET-6514] - FeedbackCollector(Component) should not >>>>>>> >>>>>> collect >>> >>>> session-scoped feedback messages >>>>>>> * [WICKET-6517] - use Ajax for multipart instead of iframe >>>>>>> >>>>>>> ** Task >>>>>>> >>>>>>> * [WICKET-6148] - Remove AjaxEventBehavior#onCheckEvent() >>>>>>> >>>>>> before >>> >>>> Wicket 8.0.0 >>>>>>> >>>>>> >
