Github user solomax commented on a diff in the pull request:
https://github.com/apache/wicket/pull/269#discussion_r176132347
--- Diff:
wicket-core/src/test/java/org/apache/wicket/protocol/http/request/WebClientInfoTest.java
---
@@ -680,6 +708,35 @@ public void konqueror()
}
}
+ @Test
+ public void ffMobile()
+ {
+ final String userAgent = "Mozilla/5.0 (iPhone; CPU iPhone OS
11_2_6 like Mac OS X) AppleWebKit/604.5.6 (KHTML, like Gecko) FxiOS/10.6b8836
Mobile/15D100 Safari/604.5.6";
+ WebClientInfo webClientInfo = new
WebClientInfo(requestCycleMock, userAgent);
+
+ assertThat(userAgent,
webClientInfo.getProperties().getBrowserVersionMajor(),
+ is(equalTo(10)));
+ assertThat(userAgent,
webClientInfo.getProperties().getBrowserVersionMinor(),
+ is(equalTo(6)));
+ assertThat(userAgent,
webClientInfo.getProperties().isBrowserMozillaFirefox(),
+ is(equalTo(true)));
+ assertThat(userAgent,
webClientInfo.getProperties().isBrowserMozilla(),
--- End diff --
This part is something I don;t really like in this PR :(
---