Github user solomax commented on a diff in the pull request:
https://github.com/apache/wicket/pull/275#discussion_r181282823
--- Diff:
wicket-core/src/main/java/org/apache/wicket/protocol/http/request/WebClientInfo.java
---
@@ -193,165 +198,117 @@ protected String getRemoteAddr(RequestCycle
requestCycle)
*/
private void init()
{
- setInternetExplorerProperties();
- setOperaProperties();
- setMozillaProperties();
- setKonquerorProperties();
- setChromeProperties();
- setEdgeProperties();
- setSafariProperties();
+ nl.basjes.parse.useragent.UserAgent parsedUserAgent =
UAA.parse(getUserAgent());
+ setInternetExplorerProperties(parsedUserAgent);
+ setKonquerorProperties(parsedUserAgent);
+ setMozillaProperties(parsedUserAgent);
+ setOperaProperties(parsedUserAgent);
+ setChromeProperties(parsedUserAgent);
+ setEdgeProperties(parsedUserAgent);
+ setSafariProperties(parsedUserAgent);
--- End diff --
can be replaced with
String agent = parsedUserAgent.getValue("AgentName");
properties.setBrowserKonqueror(UserAgent.KONQUEROR.getUaStrings().contains(agent));
properties.setBrowserChrome(UserAgent.CHROME.getUaStrings().contains(agent));
.................
setBrowserVersion(parsedUserAgent);
---
